commit 06074d8846fdf2180ed2b2b7a23226e3ba364720
author Steven Moreland <smoreland@google.com> Thu Mar 05 23:16:51 2020 +0000
committer Steven Moreland <smoreland@google.com> Thu Mar 05 23:16:51 2020 +0000
tree c7e0ded3e2d02c876a8811fe4250bd85164e6661
parent 76c0aa44bb1aeed3e611bc2ed9480b7bfd2439fd

Revert "Optimize BpBinder struct size."

This reverts commit 76c0aa44bb1aeed3e611bc2ed9480b7bfd2439fd.

Reason for revert: breaks some tests b/150837217 - will investigate why later

Change-Id: I7fe4c567a4b46d02bb31c6442e969b33b6237513

libs/binder/BpBinder.cpp

diff --git a/libs/binder/BpBinder.cpp b/libs/binder/BpBinder.cpp
index cadf15e..d2b9b8f 100644
--- a/libs/binder/BpBinder.cpp
+++ b/libs/binder/BpBinder.cpp
@@ -139,10 +139,10 @@
 BpBinder::BpBinder(int32_t handle, int32_t trackedUid)
     : mHandle(handle)
     , mStability(0)
-    , mTrackedUid(trackedUid)
-    , mAlive(true)
-    , mObitsSent(false)
+    , mAlive(1)
+    , mObitsSent(0)
     , mObituaries(nullptr)
+    , mTrackedUid(trackedUid)
 {
     ALOGV("Creating BpBinder %p handle %d\n", this, mHandle);
 
@@ -185,7 +185,7 @@
 
 bool BpBinder::isBinderAlive() const
 {
-    return mAlive;
+    return mAlive != 0;
 }
 
 status_t BpBinder::pingBinder()
@@ -236,7 +236,7 @@
 
         status_t status = IPCThreadState::self()->transact(
             mHandle, code, data, reply, flags);
-        if (status == DEAD_OBJECT) mAlive = false;
+        if (status == DEAD_OBJECT) mAlive = 0;
 
         return status;
     }
@@ -320,7 +320,7 @@
     ALOGV("Sending obituary for proxy %p handle %d, mObitsSent=%s\n",
         this, mHandle, mObitsSent ? "true" : "false");
 
-    mAlive = false;
+    mAlive = 0;
     if (mObitsSent) return;
 
     mLock.lock();
@@ -332,7 +332,7 @@
         self->flushCommands();
         mObituaries = nullptr;
     }
-    mObitsSent = true;
+    mObitsSent = 1;
     mLock.unlock();
 
     ALOGV("Reporting death of proxy %p for %zu recipients\n",