commit 0589be587f54d3d568ae18c428f2acd8d8254d1b
author Leon Scroggins III <scroggo@google.com> Fri Nov 19 16:39:20 2021 -0500
committer Leon Scroggins III <scroggo@google.com> Wed Nov 24 14:32:18 2021 -0500
tree 1fcfadbcb3adfaca09a3e1934c258ff21f657cf5
parent 80cce84582bd5074af3aab413c46d08c7e8384b3

Fix memory leak in AHardwareBuffer_isSupported

This function creates a new GraphicBuffer to call a single method on it.
Wrap it in an sp<> so that it gets deleted when it's no longer
necessary.

Bug: NA
Test: make and flash
Change-Id: I443015d63245e49e8cf38847030c9da8142cbe50

libs/nativewindow/AHardwareBuffer.cpp

diff --git a/libs/nativewindow/AHardwareBuffer.cpp b/libs/nativewindow/AHardwareBuffer.cpp
index e2f32e3..d429551 100644
--- a/libs/nativewindow/AHardwareBuffer.cpp
+++ b/libs/nativewindow/AHardwareBuffer.cpp
@@ -370,7 +370,7 @@
     if (!AHardwareBuffer_isValidDescription(desc, /*log=*/false)) return 0;
 
     bool supported = false;
-    GraphicBuffer* gBuffer = new GraphicBuffer();
+    sp<GraphicBuffer> gBuffer(new GraphicBuffer());
     status_t err = gBuffer->isSupported(desc->width, desc->height, desc->format, desc->layers,
                                         desc->usage, &supported);