commit 05290adee2d8941a112ede58944885d1835976d9
author Nandana Dutt <nandana@google.com> Fri Jan 04 15:48:09 2019 +0000
committer Nandana Dutt <nandana@google.com> Thu Jan 10 16:10:31 2019 +0000
tree a8e7cd1fe2a719a9eaa2030a60447972585d6dc1
parent dc23aff2d74257f0db9225a646e57de3b5c0768c

Add more arguments to Dumpstate binder interface

Add output file descriptors and listener to startBugreport.

Bug: 111441001
Test: builds
Change-Id: If42deb3ddc944fc3756025dba49da249dd959212

cmds/dumpstate/DumpstateService.cpp

diff --git a/cmds/dumpstate/DumpstateService.cpp b/cmds/dumpstate/DumpstateService.cpp
index 849eb44..909bdd7 100644
--- a/cmds/dumpstate/DumpstateService.cpp
+++ b/cmds/dumpstate/DumpstateService.cpp
@@ -98,9 +98,11 @@
     return binder::Status::ok();
 }
 
-binder::Status DumpstateService::startBugreport(int, int bugreport_mode, int32_t* returned_id) {
-    // TODO(111441001): return a request id here.
-    *returned_id = -1;
+binder::Status DumpstateService::startBugreport(const android::base::unique_fd& /* bugreportFd */,
+                                                const android::base::unique_fd& /* screenshotFd */,
+                                                int bugreport_mode,
+                                                const sp<IDumpstateListener>& /* listener */) {
+    // TODO(b/111441001): Pass in fds & other arguments to DumpOptions.
     MYLOGI("startBugreport() with mode: %d\n", bugreport_mode);
 
     if (bugreport_mode != Dumpstate::BugreportMode::BUGREPORT_FULL &&