Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "java/ProguardRules.h" |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 18 | #include "link/Linkers.h" |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 19 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 20 | #include "io/StringStream.h" |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 21 | #include "test/Test.h" |
| 22 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 23 | using ::aapt::io::StringOutputStream; |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 24 | using ::testing::HasSubstr; |
| 25 | using ::testing::Not; |
| 26 | |
| 27 | namespace aapt { |
| 28 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 29 | std::string GetKeepSetString(const proguard::KeepSet& set) { |
| 30 | std::string out; |
| 31 | StringOutputStream sout(&out); |
| 32 | proguard::WriteKeepSet(set, &sout); |
| 33 | sout.Flush(); |
| 34 | return out; |
| 35 | } |
| 36 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 37 | TEST(ProguardRulesTest, FragmentNameRuleIsEmitted) { |
| 38 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 39 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 40 | <fragment xmlns:android="http://schemas.android.com/apk/res/android" |
| 41 | android:name="com.foo.Bar"/>)"); |
| 42 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 43 | |
| 44 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 45 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 46 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 47 | std::string actual = GetKeepSetString(set); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 48 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 49 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 50 | } |
| 51 | |
| 52 | TEST(ProguardRulesTest, FragmentClassRuleIsEmitted) { |
| 53 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 54 | std::unique_ptr<xml::XmlResource> layout = |
| 55 | test::BuildXmlDom(R"(<fragment class="com.foo.Bar"/>)"); |
| 56 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 57 | |
| 58 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 59 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 60 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 61 | std::string actual = GetKeepSetString(set); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 62 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 63 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 64 | } |
| 65 | |
| 66 | TEST(ProguardRulesTest, FragmentNameAndClassRulesAreEmitted) { |
| 67 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 68 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 69 | <fragment xmlns:android="http://schemas.android.com/apk/res/android" |
| 70 | android:name="com.foo.Baz" |
| 71 | class="com.foo.Bar"/>)"); |
| 72 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 73 | |
| 74 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 75 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 76 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 77 | std::string actual = GetKeepSetString(set); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 78 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 79 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 80 | EXPECT_THAT(actual, HasSubstr("com.foo.Baz")); |
| 81 | } |
| 82 | |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 83 | TEST(ProguardRulesTest, NavigationFragmentNameAndClassRulesAreEmitted) { |
| 84 | std::unique_ptr<IAaptContext> context = test::ContextBuilder() |
| 85 | .SetCompilationPackage("com.base").Build(); |
| 86 | std::unique_ptr<xml::XmlResource> navigation = test::BuildXmlDom(R"( |
| 87 | <navigation |
| 88 | xmlns:android="http://schemas.android.com/apk/res/android" |
| 89 | xmlns:app="http://schemas.android.com/apk/res-auto"> |
| 90 | <custom android:id="@id/foo" |
| 91 | android:name="com.package.Foo"/> |
| 92 | <fragment android:id="@id/bar" |
| 93 | android:name="com.package.Bar"> |
| 94 | <nested android:id="@id/nested" |
| 95 | android:name=".Nested"/> |
| 96 | </fragment> |
| 97 | </navigation> |
| 98 | )"); |
| 99 | |
| 100 | navigation->file.name = test::ParseNameOrDie("navigation/graph.xml"); |
| 101 | |
| 102 | proguard::KeepSet set; |
| 103 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), navigation.get(), &set)); |
| 104 | |
| 105 | std::string actual = GetKeepSetString(set); |
| 106 | EXPECT_THAT(actual, HasSubstr("com.package.Foo")); |
| 107 | EXPECT_THAT(actual, HasSubstr("com.package.Bar")); |
| 108 | EXPECT_THAT(actual, HasSubstr("com.base.Nested")); |
| 109 | } |
| 110 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 111 | TEST(ProguardRulesTest, CustomViewRulesAreEmitted) { |
| 112 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 113 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 114 | <View xmlns:android="http://schemas.android.com/apk/res/android"> |
| 115 | <com.foo.Bar /> |
| 116 | </View>)"); |
| 117 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 118 | |
| 119 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 120 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 121 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 122 | std::string actual = GetKeepSetString(set); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 123 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 124 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 125 | } |
| 126 | |
| 127 | TEST(ProguardRulesTest, IncludedLayoutRulesAreConditional) { |
| 128 | std::unique_ptr<xml::XmlResource> bar_layout = test::BuildXmlDom(R"( |
| 129 | <View xmlns:android="http://schemas.android.com/apk/res/android"> |
| 130 | <com.foo.Bar /> |
| 131 | </View>)"); |
| 132 | bar_layout->file.name = test::ParseNameOrDie("com.foo:layout/bar"); |
| 133 | |
| 134 | ResourceTable table; |
| 135 | StdErrDiagnostics errDiagnostics; |
| 136 | table.AddResource(bar_layout->file.name, ConfigDescription::DefaultConfig(), "", |
| 137 | util::make_unique<FileReference>(), &errDiagnostics); |
| 138 | |
| 139 | std::unique_ptr<IAaptContext> context = |
| 140 | test::ContextBuilder() |
| 141 | .SetCompilationPackage("com.foo") |
| 142 | .AddSymbolSource(util::make_unique<ResourceTableSymbolSource>(&table)) |
| 143 | .Build(); |
| 144 | |
| 145 | std::unique_ptr<xml::XmlResource> foo_layout = test::BuildXmlDom(R"( |
| 146 | <View xmlns:android="http://schemas.android.com/apk/res/android"> |
| 147 | <include layout="@layout/bar" /> |
| 148 | </View>)"); |
| 149 | foo_layout->file.name = test::ParseNameOrDie("com.foo:layout/foo"); |
| 150 | |
| 151 | XmlReferenceLinker xml_linker; |
| 152 | ASSERT_TRUE(xml_linker.Consume(context.get(), bar_layout.get())); |
| 153 | ASSERT_TRUE(xml_linker.Consume(context.get(), foo_layout.get())); |
| 154 | |
| 155 | proguard::KeepSet set = proguard::KeepSet(true); |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 156 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), bar_layout.get(), &set)); |
| 157 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), foo_layout.get(), &set)); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 158 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 159 | std::string actual = GetKeepSetString(set); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 160 | |
Adam Koski | 09ef94e | 2017-11-10 11:15:55 -0800 | [diff] [blame] | 161 | EXPECT_THAT(actual, HasSubstr("-if class **.R$layout")); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 162 | EXPECT_THAT(actual, HasSubstr("-keep class com.foo.Bar { <init>(...); }")); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 163 | EXPECT_THAT(actual, HasSubstr("int foo")); |
| 164 | EXPECT_THAT(actual, HasSubstr("int bar")); |
| 165 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 166 | } |
| 167 | |
| 168 | TEST(ProguardRulesTest, AliasedLayoutRulesAreConditional) { |
| 169 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 170 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 171 | <View xmlns:android="http://schemas.android.com/apk/res/android"> |
| 172 | <com.foo.Bar /> |
| 173 | </View>)"); |
| 174 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 175 | |
| 176 | proguard::KeepSet set = proguard::KeepSet(true); |
| 177 | set.AddReference({test::ParseNameOrDie("layout/bar"), {}}, layout->file.name); |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 178 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 179 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 180 | std::string actual = GetKeepSetString(set); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 181 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 182 | EXPECT_THAT(actual, HasSubstr("-keep class com.foo.Bar { <init>(...); }")); |
Adam Koski | 09ef94e | 2017-11-10 11:15:55 -0800 | [diff] [blame] | 183 | EXPECT_THAT(actual, HasSubstr("-if class **.R$layout")); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 184 | EXPECT_THAT(actual, HasSubstr("int foo")); |
| 185 | EXPECT_THAT(actual, HasSubstr("int bar")); |
| 186 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 187 | } |
| 188 | |
| 189 | TEST(ProguardRulesTest, NonLayoutReferencesAreUnconditional) { |
| 190 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 191 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 192 | <View xmlns:android="http://schemas.android.com/apk/res/android"> |
| 193 | <com.foo.Bar /> |
| 194 | </View>)"); |
| 195 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 196 | |
| 197 | proguard::KeepSet set = proguard::KeepSet(true); |
| 198 | set.AddReference({test::ParseNameOrDie("style/MyStyle"), {}}, layout->file.name); |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 199 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 200 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 201 | std::string actual = GetKeepSetString(set); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 202 | |
Adam Koski | 09ef94e | 2017-11-10 11:15:55 -0800 | [diff] [blame] | 203 | EXPECT_THAT(actual, Not(HasSubstr("-if"))); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 204 | EXPECT_THAT(actual, HasSubstr("-keep class com.foo.Bar { <init>(...); }")); |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 205 | } |
| 206 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 207 | TEST(ProguardRulesTest, ViewOnClickRuleIsEmitted) { |
| 208 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 209 | std::unique_ptr<xml::XmlResource> layout = test::BuildXmlDom(R"( |
| 210 | <View xmlns:android="http://schemas.android.com/apk/res/android" |
| 211 | android:onClick="bar_method" />)"); |
| 212 | layout->file.name = test::ParseNameOrDie("layout/foo"); |
| 213 | |
| 214 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 215 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), layout.get(), &set)); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 216 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 217 | std::string actual = GetKeepSetString(set); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 218 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 219 | EXPECT_THAT(actual, HasSubstr("bar_method")); |
| 220 | } |
| 221 | |
| 222 | TEST(ProguardRulesTest, MenuRulesAreEmitted) { |
| 223 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 224 | std::unique_ptr<xml::XmlResource> menu = test::BuildXmlDom(R"( |
| 225 | <menu xmlns:android="http://schemas.android.com/apk/res/android"> |
| 226 | <item android:onClick="on_click" |
| 227 | android:actionViewClass="com.foo.Bar" |
| 228 | android:actionProviderClass="com.foo.Baz" |
| 229 | android:name="com.foo.Bat" /> |
| 230 | </menu>)"); |
| 231 | menu->file.name = test::ParseNameOrDie("menu/foo"); |
| 232 | |
| 233 | proguard::KeepSet set; |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 234 | ASSERT_TRUE(proguard::CollectProguardRules(context.get(), menu.get(), &set)); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 235 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 236 | std::string actual = GetKeepSetString(set); |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 237 | |
Adam Lesinski | f762df2 | 2017-06-26 16:39:03 -0700 | [diff] [blame] | 238 | EXPECT_THAT(actual, HasSubstr("on_click")); |
| 239 | EXPECT_THAT(actual, HasSubstr("com.foo.Bar")); |
| 240 | EXPECT_THAT(actual, HasSubstr("com.foo.Baz")); |
| 241 | EXPECT_THAT(actual, Not(HasSubstr("com.foo.Bat"))); |
| 242 | } |
| 243 | |
| 244 | } // namespace aapt |