| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1 | /* | 
|  | 2 | * Copyright (C) 2015 The Android Open Source Project | 
|  | 3 | * | 
|  | 4 | * Licensed under the Apache License, Version 2.0 (the "License"); | 
|  | 5 | * you may not use this file except in compliance with the License. | 
|  | 6 | * You may obtain a copy of the License at | 
|  | 7 | * | 
|  | 8 | *      http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 9 | * | 
|  | 10 | * Unless required by applicable law or agreed to in writing, software | 
|  | 11 | * distributed under the License is distributed on an "AS IS" BASIS, | 
|  | 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 13 | * See the License for the specific language governing permissions and | 
|  | 14 | * limitations under the License. | 
|  | 15 | */ | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 16 | #include "ResourceParser.h" | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 17 |  | 
|  | 18 | #include <functional> | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 19 | #include <limits> | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 20 | #include <sstream> | 
|  | 21 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 22 | #include <android-base/logging.h> | 
|  | 23 | #include <idmap2/Policies.h> | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 24 |  | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 25 | #include "ResourceTable.h" | 
|  | 26 | #include "ResourceUtils.h" | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 27 | #include "ResourceValues.h" | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 28 | #include "ValueVisitor.h" | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 29 | #include "text/Utf8Iterator.h" | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 30 | #include "util/ImmutableMap.h" | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 31 |  | 
| Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 32 | #include "util/Util.h" | 
| Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 33 | #include "xml/XmlPullParser.h" | 
| Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 34 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 35 | using ::aapt::ResourceUtils::StringBuilder; | 
|  | 36 | using ::aapt::text::Utf8Iterator; | 
| MÃ¥rten Kongstad | 24c9aa6 | 2018-06-20 08:46:41 +0200 | [diff] [blame] | 37 | using ::android::ConfigDescription; | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 38 | using ::android::StringPiece; | 
| Adam Lesinski | d5083f6 | 2017-01-16 15:07:21 -0800 | [diff] [blame] | 39 |  | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 40 | using android::idmap2::policy::kPolicyStringToFlag; | 
|  | 41 |  | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 42 | namespace aapt { | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 43 | namespace { | 
|  | 44 | constexpr const char* kPublicGroupTag = "public-group"; | 
|  | 45 | constexpr const char* kStagingPublicGroupTag = "staging-public-group"; | 
| Ryan Mitchell | 2fedba9 | 2021-04-23 07:47:38 -0700 | [diff] [blame] | 46 | constexpr const char* kStagingPublicGroupFinalTag = "staging-public-group-final"; | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 47 | }  // namespace | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 48 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 49 | constexpr const char* sXliffNamespaceUri = "urn:oasis:names:tc:xliff:document:1.2"; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 50 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 51 | // Returns true if the element is <skip> or <eat-comment> and can be safely ignored. | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 52 | static bool ShouldIgnoreElement(StringPiece ns, StringPiece name) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 53 | return ns.empty() && (name == "skip" || name == "eat-comment"); | 
| Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 54 | } | 
|  | 55 |  | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 56 | static uint32_t ParseFormatTypeNoEnumsOrFlags(StringPiece piece) { | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 57 | if (piece == "reference") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 58 | return android::ResTable_map::TYPE_REFERENCE; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 59 | } else if (piece == "string") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 60 | return android::ResTable_map::TYPE_STRING; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 61 | } else if (piece == "integer") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 62 | return android::ResTable_map::TYPE_INTEGER; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 63 | } else if (piece == "boolean") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 64 | return android::ResTable_map::TYPE_BOOLEAN; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 65 | } else if (piece == "color") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 66 | return android::ResTable_map::TYPE_COLOR; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 67 | } else if (piece == "float") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 68 | return android::ResTable_map::TYPE_FLOAT; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 69 | } else if (piece == "dimension") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 70 | return android::ResTable_map::TYPE_DIMENSION; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 71 | } else if (piece == "fraction") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 72 | return android::ResTable_map::TYPE_FRACTION; | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 73 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 74 | return 0; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 75 | } | 
|  | 76 |  | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 77 | static uint32_t ParseFormatType(StringPiece piece) { | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 78 | if (piece == "enum") { | 
|  | 79 | return android::ResTable_map::TYPE_ENUM; | 
|  | 80 | } else if (piece == "flags") { | 
|  | 81 | return android::ResTable_map::TYPE_FLAGS; | 
|  | 82 | } | 
|  | 83 | return ParseFormatTypeNoEnumsOrFlags(piece); | 
|  | 84 | } | 
|  | 85 |  | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 86 | static uint32_t ParseFormatAttribute(StringPiece str) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 87 | uint32_t mask = 0; | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 88 | for (StringPiece part : util::Tokenize(str, '|')) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 89 | StringPiece trimmed_part = util::TrimWhitespace(part); | 
|  | 90 | uint32_t type = ParseFormatType(trimmed_part); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 91 | if (type == 0) { | 
|  | 92 | return 0; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 93 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 94 | mask |= type; | 
|  | 95 | } | 
|  | 96 | return mask; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 97 | } | 
|  | 98 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 99 | // A parsed resource ready to be added to the ResourceTable. | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 100 | struct ParsedResource { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 101 | ResourceName name; | 
|  | 102 | ConfigDescription config; | 
|  | 103 | std::string product; | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 104 | android::Source source; | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 105 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 106 | ResourceId id; | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 107 | Visibility::Level visibility_level = Visibility::Level::kUndefined; | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 108 | bool staged_api = false; | 
| Adam Lesinski | 4488f1c | 2017-05-26 17:33:38 -0700 | [diff] [blame] | 109 | bool allow_new = false; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 110 | std::optional<OverlayableItem> overlayable_item; | 
|  | 111 | std::optional<StagedId> staged_alias; | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 112 | std::optional<FeatureFlagAttribute> flag; | 
|  | 113 | FlagStatus flag_status; | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 114 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 115 | std::string comment; | 
|  | 116 | std::unique_ptr<Value> value; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 117 | std::list<ParsedResource> child_resources; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 118 | }; | 
|  | 119 |  | 
|  | 120 | // Recursively adds resources to the ResourceTable. | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 121 | static bool AddResourcesToTable(ResourceTable* table, android::IDiagnostics* diag, | 
|  | 122 | ParsedResource* res) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 123 | StringPiece trimmed_comment = util::TrimWhitespace(res->comment); | 
|  | 124 | if (trimmed_comment.size() != res->comment.size()) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 125 | // Only if there was a change do we re-assign. | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 126 | res->comment = std::string(trimmed_comment); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 127 | } | 
| Adam Lesinski | 7656554 | 2016-03-10 21:55:04 -0800 | [diff] [blame] | 128 |  | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 129 | NewResourceBuilder res_builder(res->name); | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 130 | if (res->visibility_level != Visibility::Level::kUndefined) { | 
|  | 131 | Visibility visibility; | 
|  | 132 | visibility.level = res->visibility_level; | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 133 | visibility.staged_api = res->staged_api; | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 134 | visibility.source = res->source; | 
|  | 135 | visibility.comment = res->comment; | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 136 | res_builder.SetVisibility(visibility); | 
|  | 137 | } | 
|  | 138 |  | 
|  | 139 | if (res->id.is_valid()) { | 
|  | 140 | res_builder.SetId(res->id); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 141 | } | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 142 |  | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 143 | if (res->allow_new) { | 
|  | 144 | AllowNew allow_new; | 
|  | 145 | allow_new.source = res->source; | 
|  | 146 | allow_new.comment = res->comment; | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 147 | res_builder.SetAllowNew(allow_new); | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 148 | } | 
|  | 149 |  | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 150 | if (res->overlayable_item) { | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 151 | res_builder.SetOverlayable(res->overlayable_item.value()); | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 152 | } | 
|  | 153 |  | 
|  | 154 | if (res->value != nullptr) { | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 155 | res->value->SetFlag(res->flag); | 
| Jeremy Meyer | d52bd68 | 2024-08-14 11:16:58 -0700 | [diff] [blame] | 156 | res->value->SetFlagStatus(res->flag_status); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 157 | // Attach the comment, source and config to the value. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 158 | res->value->SetComment(std::move(res->comment)); | 
|  | 159 | res->value->SetSource(std::move(res->source)); | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 160 | res_builder.SetValue(std::move(res->value), res->config, res->product); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 161 | } | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 162 |  | 
| Ryan Mitchell | 2fedba9 | 2021-04-23 07:47:38 -0700 | [diff] [blame] | 163 | if (res->staged_alias) { | 
|  | 164 | res_builder.SetStagedId(res->staged_alias.value()); | 
|  | 165 | } | 
|  | 166 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 167 | bool error = false; | 
| Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 168 | if (!res->name.entry.empty()) { | 
|  | 169 | if (!table->AddResource(res_builder.Build(), diag)) { | 
|  | 170 | return false; | 
|  | 171 | } | 
|  | 172 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 173 | for (ParsedResource& child : res->child_resources) { | 
|  | 174 | error |= !AddResourcesToTable(table, diag, &child); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 175 | } | 
|  | 176 | return !error; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 177 | } | 
|  | 178 |  | 
|  | 179 | // Convenient aliases for more readable function calls. | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 180 | enum { kAllowRawString = true, kNoRawString = false }; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 181 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 182 | ResourceParser::ResourceParser(android::IDiagnostics* diag, ResourceTable* table, | 
|  | 183 | const android::Source& source, const ConfigDescription& config, | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 184 | const ResourceParserOptions& options) | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 185 | : diag_(diag), table_(table), source_(source), config_(config), options_(options) { | 
|  | 186 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 187 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 188 | // Base class Node for representing the various Spans and UntranslatableSections of an XML string. | 
|  | 189 | // This will be used to traverse and flatten the XML string into a single std::string, with all | 
|  | 190 | // Span and Untranslatable data maintained in parallel, as indices into the string. | 
|  | 191 | class Node { | 
|  | 192 | public: | 
|  | 193 | virtual ~Node() = default; | 
|  | 194 |  | 
|  | 195 | // Adds the given child node to this parent node's set of child nodes, moving ownership to the | 
|  | 196 | // parent node as well. | 
|  | 197 | // Returns a pointer to the child node that was added as a convenience. | 
|  | 198 | template <typename T> | 
|  | 199 | T* AddChild(std::unique_ptr<T> node) { | 
|  | 200 | T* raw_ptr = node.get(); | 
|  | 201 | children.push_back(std::move(node)); | 
|  | 202 | return raw_ptr; | 
|  | 203 | } | 
|  | 204 |  | 
|  | 205 | virtual void Build(StringBuilder* builder) const { | 
|  | 206 | for (const auto& child : children) { | 
|  | 207 | child->Build(builder); | 
|  | 208 | } | 
|  | 209 | } | 
|  | 210 |  | 
|  | 211 | std::vector<std::unique_ptr<Node>> children; | 
|  | 212 | }; | 
|  | 213 |  | 
|  | 214 | // A chunk of text in the XML string. This lives between other tags, such as XLIFF tags and Spans. | 
|  | 215 | class SegmentNode : public Node { | 
|  | 216 | public: | 
|  | 217 | std::string data; | 
|  | 218 |  | 
|  | 219 | void Build(StringBuilder* builder) const override { | 
|  | 220 | builder->AppendText(data); | 
|  | 221 | } | 
|  | 222 | }; | 
|  | 223 |  | 
|  | 224 | // A tag that will be encoded into the final flattened string. Tags like <b> or <i>. | 
|  | 225 | class SpanNode : public Node { | 
|  | 226 | public: | 
|  | 227 | std::string name; | 
|  | 228 |  | 
|  | 229 | void Build(StringBuilder* builder) const override { | 
|  | 230 | StringBuilder::SpanHandle span_handle = builder->StartSpan(name); | 
|  | 231 | Node::Build(builder); | 
|  | 232 | builder->EndSpan(span_handle); | 
|  | 233 | } | 
|  | 234 | }; | 
|  | 235 |  | 
|  | 236 | // An XLIFF 'g' tag, which marks a section of the string as untranslatable. | 
|  | 237 | class UntranslatableNode : public Node { | 
|  | 238 | public: | 
|  | 239 | void Build(StringBuilder* builder) const override { | 
|  | 240 | StringBuilder::UntranslatableHandle handle = builder->StartUntranslatable(); | 
|  | 241 | Node::Build(builder); | 
|  | 242 | builder->EndUntranslatable(handle); | 
|  | 243 | } | 
|  | 244 | }; | 
|  | 245 |  | 
|  | 246 | // Build a string from XML that converts nested elements into Span objects. | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 247 | bool ResourceParser::FlattenXmlSubtree( | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 248 | xml::XmlPullParser* parser, std::string* out_raw_string, android::StyleString* out_style_string, | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 249 | std::vector<UntranslatableSection>* out_untranslatable_sections) { | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 250 | std::string raw_string; | 
|  | 251 | std::string current_text; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 252 |  | 
|  | 253 | // The first occurrence of a <xliff:g> tag. Nested <xliff:g> tags are illegal. | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 254 | std::optional<size_t> untranslatable_start_depth; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 255 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 256 | Node root; | 
|  | 257 | std::vector<Node*> node_stack; | 
|  | 258 | node_stack.push_back(&root); | 
|  | 259 |  | 
|  | 260 | bool saw_span_node = false; | 
|  | 261 | SegmentNode* first_segment = nullptr; | 
|  | 262 | SegmentNode* last_segment = nullptr; | 
|  | 263 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 264 | size_t depth = 1; | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 265 | while (depth > 0 && xml::XmlPullParser::IsGoodEvent(parser->Next())) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 266 | const xml::XmlPullParser::Event event = parser->event(); | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 267 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 268 | // First take care of any SegmentNodes that should be created. | 
| Ryan Mitchell | cb76d73 | 2018-06-05 10:15:04 -0700 | [diff] [blame] | 269 | if (event == xml::XmlPullParser::Event::kStartElement | 
| Ryan Mitchell | 1d358ff | 2019-03-06 15:06:49 -0800 | [diff] [blame] | 270 | || event == xml::XmlPullParser::Event::kEndElement) { | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 271 | if (!current_text.empty()) { | 
| Ryan Mitchell | 1d358ff | 2019-03-06 15:06:49 -0800 | [diff] [blame] | 272 | auto segment_node = util::make_unique<SegmentNode>(); | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 273 | segment_node->data = std::move(current_text); | 
| Ryan Mitchell | cb76d73 | 2018-06-05 10:15:04 -0700 | [diff] [blame] | 274 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 275 | last_segment = node_stack.back()->AddChild(std::move(segment_node)); | 
|  | 276 | if (first_segment == nullptr) { | 
|  | 277 | first_segment = last_segment; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 278 | } | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 279 | current_text = {}; | 
|  | 280 | } | 
|  | 281 | } | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 282 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 283 | switch (event) { | 
|  | 284 | case xml::XmlPullParser::Event::kText: { | 
|  | 285 | current_text += parser->text(); | 
|  | 286 | raw_string += parser->text(); | 
|  | 287 | } break; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 288 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 289 | case xml::XmlPullParser::Event::kStartElement: { | 
|  | 290 | if (parser->element_namespace().empty()) { | 
|  | 291 | // This is an HTML tag which we encode as a span. Add it to the span stack. | 
|  | 292 | std::unique_ptr<SpanNode> span_node = util::make_unique<SpanNode>(); | 
|  | 293 | span_node->name = parser->element_name(); | 
|  | 294 | const auto end_attr_iter = parser->end_attributes(); | 
|  | 295 | for (auto attr_iter = parser->begin_attributes(); attr_iter != end_attr_iter; | 
|  | 296 | ++attr_iter) { | 
|  | 297 | span_node->name += ";"; | 
|  | 298 | span_node->name += attr_iter->name; | 
|  | 299 | span_node->name += "="; | 
|  | 300 | span_node->name += attr_iter->value; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 301 | } | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 302 |  | 
|  | 303 | node_stack.push_back(node_stack.back()->AddChild(std::move(span_node))); | 
|  | 304 | saw_span_node = true; | 
|  | 305 | } else if (parser->element_namespace() == sXliffNamespaceUri) { | 
|  | 306 | // This is an XLIFF tag, which is not encoded as a span. | 
|  | 307 | if (parser->element_name() == "g") { | 
|  | 308 | // Check that an 'untranslatable' tag is not already being processed. Nested | 
|  | 309 | // <xliff:g> tags are illegal. | 
|  | 310 | if (untranslatable_start_depth) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 311 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 312 | << "illegal nested XLIFF 'g' tag"); | 
|  | 313 | return false; | 
|  | 314 | } else { | 
|  | 315 | // Mark the beginning of an 'untranslatable' section. | 
|  | 316 | untranslatable_start_depth = depth; | 
|  | 317 | node_stack.push_back( | 
|  | 318 | node_stack.back()->AddChild(util::make_unique<UntranslatableNode>())); | 
|  | 319 | } | 
|  | 320 | } else { | 
|  | 321 | // Ignore unknown XLIFF tags, but don't warn. | 
|  | 322 | node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>())); | 
|  | 323 | } | 
|  | 324 | } else { | 
|  | 325 | // Besides XLIFF, any other namespaced tag is unsupported and ignored. | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 326 | diag_->Warn(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 327 | << "ignoring element '" << parser->element_name() | 
|  | 328 | << "' with unknown namespace '" << parser->element_namespace() << "'"); | 
|  | 329 | node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>())); | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 330 | } | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 331 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 332 | // Enter one level inside the element. | 
|  | 333 | depth++; | 
|  | 334 | } break; | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 335 |  | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 336 | case xml::XmlPullParser::Event::kEndElement: { | 
|  | 337 | // Return one level from within the element. | 
|  | 338 | depth--; | 
|  | 339 | if (depth == 0) { | 
|  | 340 | break; | 
|  | 341 | } | 
|  | 342 |  | 
|  | 343 | node_stack.pop_back(); | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 344 | if (untranslatable_start_depth == depth) { | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 345 | // This is the end of an untranslatable section. | 
|  | 346 | untranslatable_start_depth = {}; | 
|  | 347 | } | 
|  | 348 | } break; | 
|  | 349 |  | 
|  | 350 | default: | 
|  | 351 | // ignore. | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 352 | break; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 353 | } | 
|  | 354 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 355 |  | 
| Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 356 | // Validity check to make sure we processed all the nodes. | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 357 | CHECK(node_stack.size() == 1u); | 
|  | 358 | CHECK(node_stack.back() == &root); | 
|  | 359 |  | 
|  | 360 | if (!saw_span_node) { | 
|  | 361 | // If there were no spans, we must treat this string a little differently (according to AAPT). | 
|  | 362 | // Find and strip the leading whitespace from the first segment, and the trailing whitespace | 
|  | 363 | // from the last segment. | 
|  | 364 | if (first_segment != nullptr) { | 
|  | 365 | // Trim leading whitespace. | 
|  | 366 | StringPiece trimmed = util::TrimLeadingWhitespace(first_segment->data); | 
|  | 367 | if (trimmed.size() != first_segment->data.size()) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 368 | first_segment->data = std::string(trimmed); | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 369 | } | 
|  | 370 | } | 
|  | 371 |  | 
|  | 372 | if (last_segment != nullptr) { | 
|  | 373 | // Trim trailing whitespace. | 
|  | 374 | StringPiece trimmed = util::TrimTrailingWhitespace(last_segment->data); | 
|  | 375 | if (trimmed.size() != last_segment->data.size()) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 376 | last_segment->data = std::string(trimmed); | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 377 | } | 
|  | 378 | } | 
|  | 379 | } | 
|  | 380 |  | 
|  | 381 | // Have the XML structure flatten itself into the StringBuilder. The StringBuilder will take | 
|  | 382 | // care of recording the correctly adjusted Spans and UntranslatableSections. | 
|  | 383 | StringBuilder builder; | 
|  | 384 | root.Build(&builder); | 
|  | 385 | if (!builder) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 386 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
|  | 387 | << builder.GetError()); | 
| Adam Lesinski | 2eed52e | 2018-02-21 15:55:58 -0800 | [diff] [blame] | 388 | return false; | 
|  | 389 | } | 
|  | 390 |  | 
|  | 391 | ResourceUtils::FlattenedXmlString flattened_string = builder.GetFlattenedString(); | 
|  | 392 | *out_raw_string = std::move(raw_string); | 
|  | 393 | *out_untranslatable_sections = std::move(flattened_string.untranslatable_sections); | 
|  | 394 | out_style_string->str = std::move(flattened_string.text); | 
|  | 395 | out_style_string->spans = std::move(flattened_string.spans); | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 396 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 397 | } | 
|  | 398 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 399 | bool ResourceParser::Parse(xml::XmlPullParser* parser) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 400 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 401 | const size_t depth = parser->depth(); | 
|  | 402 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 403 | if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 404 | // Skip comments and text. | 
|  | 405 | continue; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 406 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 407 |  | 
| Adam Lesinski | 060b53d | 2017-07-28 17:10:35 -0700 | [diff] [blame] | 408 | if (!parser->element_namespace().empty() || parser->element_name() != "resources") { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 409 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 410 | << "root element must be <resources>"); | 
|  | 411 | return false; | 
|  | 412 | } | 
|  | 413 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 414 | error |= !ParseResources(parser); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 415 | break; | 
|  | 416 | }; | 
|  | 417 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 418 | if (parser->event() == xml::XmlPullParser::Event::kBadDocument) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 419 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 420 | << "xml parser error: " << parser->error()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 421 | return false; | 
|  | 422 | } | 
|  | 423 | return !error; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 424 | } | 
|  | 425 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 426 | bool ResourceParser::ParseResources(xml::XmlPullParser* parser) { | 
|  | 427 | std::set<ResourceName> stripped_resources; | 
| Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 428 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 429 | bool error = false; | 
|  | 430 | std::string comment; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 431 | const size_t depth = parser->depth(); | 
|  | 432 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 433 | const xml::XmlPullParser::Event event = parser->event(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 434 | if (event == xml::XmlPullParser::Event::kComment) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 435 | comment = parser->comment(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 436 | continue; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 437 | } | 
| Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 438 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 439 | if (event == xml::XmlPullParser::Event::kText) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 440 | if (!util::TrimWhitespace(parser->text()).empty()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 441 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 442 | << "plain text not allowed here"); | 
|  | 443 | error = true; | 
|  | 444 | } | 
|  | 445 | continue; | 
| Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 446 | } | 
|  | 447 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 448 | CHECK(event == xml::XmlPullParser::Event::kStartElement); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 449 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 450 | if (!parser->element_namespace().empty()) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 451 | // Skip unknown namespace. | 
|  | 452 | continue; | 
|  | 453 | } | 
|  | 454 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 455 | std::string element_name = parser->element_name(); | 
|  | 456 | if (element_name == "skip" || element_name == "eat-comment") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 457 | comment = ""; | 
|  | 458 | continue; | 
|  | 459 | } | 
|  | 460 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 461 | ParsedResource parsed_resource; | 
|  | 462 | parsed_resource.config = config_; | 
|  | 463 | parsed_resource.source = source_.WithLine(parser->line_number()); | 
|  | 464 | parsed_resource.comment = std::move(comment); | 
| Felka Chang | 5cf069b | 2021-10-27 00:06:04 +0800 | [diff] [blame] | 465 | comment.clear(); | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 466 | if (options_.visibility) { | 
|  | 467 | parsed_resource.visibility_level = options_.visibility.value(); | 
|  | 468 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 469 |  | 
|  | 470 | // Extract the product name if it exists. | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 471 | if (std::optional<StringPiece> maybe_product = xml::FindNonEmptyAttribute(parser, "product")) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 472 | parsed_resource.product = std::string(maybe_product.value()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 473 | } | 
|  | 474 |  | 
|  | 475 | // Parse the resource regardless of product. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 476 | if (!ParseResource(parser, &parsed_resource)) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 477 | error = true; | 
|  | 478 | continue; | 
|  | 479 | } | 
|  | 480 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 481 | if (!AddResourcesToTable(table_, diag_, &parsed_resource)) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 482 | error = true; | 
|  | 483 | } | 
|  | 484 | } | 
|  | 485 |  | 
|  | 486 | // Check that we included at least one variant of each stripped resource. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 487 | for (const ResourceName& stripped_resource : stripped_resources) { | 
|  | 488 | if (!table_->FindResource(stripped_resource)) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 489 | // Failed to find the resource. | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 490 | diag_->Error(android::DiagMessage(source_) | 
|  | 491 | << "resource '" << stripped_resource | 
|  | 492 | << "' was filtered out but no product variant remains"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 493 | error = true; | 
|  | 494 | } | 
|  | 495 | } | 
|  | 496 |  | 
|  | 497 | return !error; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 498 | } | 
|  | 499 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 500 | bool ResourceParser::ParseResource(xml::XmlPullParser* parser, | 
|  | 501 | ParsedResource* out_resource) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 502 | struct ItemTypeFormat { | 
|  | 503 | ResourceType type; | 
|  | 504 | uint32_t format; | 
|  | 505 | }; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 506 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 507 | using BagParseFunc = std::function<bool(ResourceParser*, xml::XmlPullParser*, | 
|  | 508 | ParsedResource*)>; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 509 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 510 | static const auto elToItemMap = ImmutableMap<std::string, ItemTypeFormat>::CreatePreSorted({ | 
|  | 511 | {"bool", {ResourceType::kBool, android::ResTable_map::TYPE_BOOLEAN}}, | 
|  | 512 | {"color", {ResourceType::kColor, android::ResTable_map::TYPE_COLOR}}, | 
|  | 513 | {"configVarying", {ResourceType::kConfigVarying, android::ResTable_map::TYPE_ANY}}, | 
|  | 514 | {"dimen", | 
|  | 515 | {ResourceType::kDimen, | 
|  | 516 | android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION | | 
|  | 517 | android::ResTable_map::TYPE_DIMENSION}}, | 
|  | 518 | {"drawable", {ResourceType::kDrawable, android::ResTable_map::TYPE_COLOR}}, | 
|  | 519 | {"fraction", | 
|  | 520 | {ResourceType::kFraction, | 
|  | 521 | android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION | | 
|  | 522 | android::ResTable_map::TYPE_DIMENSION}}, | 
|  | 523 | {"integer", {ResourceType::kInteger, android::ResTable_map::TYPE_INTEGER}}, | 
|  | 524 | {"string", {ResourceType::kString, android::ResTable_map::TYPE_STRING}}, | 
|  | 525 | }); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 526 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 527 | static const auto elToBagMap = ImmutableMap<std::string, BagParseFunc>::CreatePreSorted({ | 
|  | 528 | {"add-resource", std::mem_fn(&ResourceParser::ParseAddResource)}, | 
|  | 529 | {"array", std::mem_fn(&ResourceParser::ParseArray)}, | 
|  | 530 | {"attr", std::mem_fn(&ResourceParser::ParseAttr)}, | 
|  | 531 | {"configVarying", | 
|  | 532 | std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kConfigVarying, | 
|  | 533 | std::placeholders::_2, std::placeholders::_3)}, | 
|  | 534 | {"declare-styleable", std::mem_fn(&ResourceParser::ParseDeclareStyleable)}, | 
|  | 535 | {"integer-array", std::mem_fn(&ResourceParser::ParseIntegerArray)}, | 
|  | 536 | {"java-symbol", std::mem_fn(&ResourceParser::ParseSymbol)}, | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 537 | {"overlayable", std::mem_fn(&ResourceParser::ParseOverlayable)}, | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 538 | {"plurals", std::mem_fn(&ResourceParser::ParsePlural)}, | 
|  | 539 | {"public", std::mem_fn(&ResourceParser::ParsePublic)}, | 
|  | 540 | {"public-group", std::mem_fn(&ResourceParser::ParsePublicGroup)}, | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 541 | {"staging-public-group", std::mem_fn(&ResourceParser::ParseStagingPublicGroup)}, | 
| Ryan Mitchell | 2fedba9 | 2021-04-23 07:47:38 -0700 | [diff] [blame] | 542 | {"staging-public-group-final", std::mem_fn(&ResourceParser::ParseStagingPublicGroupFinal)}, | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 543 | {"string-array", std::mem_fn(&ResourceParser::ParseStringArray)}, | 
|  | 544 | {"style", std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kStyle, | 
|  | 545 | std::placeholders::_2, std::placeholders::_3)}, | 
|  | 546 | {"symbol", std::mem_fn(&ResourceParser::ParseSymbol)}, | 
|  | 547 | }); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 548 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 549 | std::string resource_type = parser->element_name(); | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 550 | out_resource->flag = GetFlag(parser); | 
|  | 551 | std::string error; | 
|  | 552 | auto flag_status = GetFlagStatus(out_resource->flag, options_.feature_flag_values, &error); | 
|  | 553 | if (flag_status) { | 
|  | 554 | out_resource->flag_status = flag_status.value(); | 
|  | 555 | } else { | 
|  | 556 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) << error); | 
| Jeremy Meyer | d52bd68 | 2024-08-14 11:16:58 -0700 | [diff] [blame] | 557 | return false; | 
| Jeremy Meyer | 211bec2 | 2024-06-04 14:22:03 -0700 | [diff] [blame] | 558 | } | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 559 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 560 | // The value format accepted for this resource. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 561 | uint32_t resource_format = 0u; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 562 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 563 | bool can_be_item = true; | 
|  | 564 | bool can_be_bag = true; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 565 | if (resource_type == "item") { | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 566 | can_be_bag = false; | 
|  | 567 |  | 
| Adam Lesinski | e597d68 | 2017-06-01 17:16:44 -0700 | [diff] [blame] | 568 | // The default format for <item> is any. If a format attribute is present, that one will | 
|  | 569 | // override the default. | 
|  | 570 | resource_format = android::ResTable_map::TYPE_ANY; | 
|  | 571 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 572 | // Items have their type encoded in the type attribute. | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 573 | if (std::optional<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 574 | resource_type = std::string(maybe_type.value()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 575 | } else { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 576 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 577 | << "<item> must have a 'type' attribute"); | 
|  | 578 | return false; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 579 | } | 
|  | 580 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 581 | if (std::optional<StringPiece> maybe_format = xml::FindNonEmptyAttribute(parser, "format")) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 582 | // An explicit format for this resource was specified. The resource will | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 583 | // retain its type in its name, but the accepted value for this type is | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 584 | // overridden. | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 585 | resource_format = ParseFormatTypeNoEnumsOrFlags(maybe_format.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 586 | if (!resource_format) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 587 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 588 | << "'" << maybe_format.value() << "' is an invalid format"); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 589 | return false; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 590 | } | 
|  | 591 | } | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 592 | } else if (resource_type == "bag") { | 
|  | 593 | can_be_item = false; | 
|  | 594 |  | 
|  | 595 | // Bags have their type encoded in the type attribute. | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 596 | if (std::optional<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 597 | resource_type = std::string(maybe_type.value()); | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 598 | } else { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 599 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 600 | << "<bag> must have a 'type' attribute"); | 
|  | 601 | return false; | 
|  | 602 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 603 | } | 
|  | 604 |  | 
|  | 605 | // Get the name of the resource. This will be checked later, because not all | 
|  | 606 | // XML elements require a name. | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 607 | std::optional<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 608 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 609 | if (resource_type == "id") { | 
|  | 610 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 611 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 612 | << "<" << parser->element_name() << "> missing 'name' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 613 | return false; | 
|  | 614 | } | 
|  | 615 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 616 | out_resource->name.type = | 
|  | 617 | ResourceNamedTypeWithDefaultName(ResourceType::kId).ToResourceNamedType(); | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 618 | out_resource->name.entry = std::string(maybe_name.value()); | 
| y | 9efbbef | 2018-04-18 11:29:09 -0700 | [diff] [blame] | 619 |  | 
|  | 620 | // Ids either represent a unique resource id or reference another resource id | 
|  | 621 | auto item = ParseItem(parser, out_resource, resource_format); | 
|  | 622 | if (!item) { | 
|  | 623 | return false; | 
|  | 624 | } | 
|  | 625 |  | 
|  | 626 | String* empty = ValueCast<String>(out_resource->value.get()); | 
|  | 627 | if (empty && *empty->value == "") { | 
|  | 628 | // If no inner element exists, represent a unique identifier | 
|  | 629 | out_resource->value = util::make_unique<Id>(); | 
|  | 630 | } else { | 
| y | 9efbbef | 2018-04-18 11:29:09 -0700 | [diff] [blame] | 631 | Reference* ref = ValueCast<Reference>(out_resource->value.get()); | 
| Ryan Mitchell | eaf77e1 | 2018-04-25 15:00:50 -0700 | [diff] [blame] | 632 | if (ref && !ref->name && !ref->id) { | 
|  | 633 | // A null reference also means there is no inner element when ids are in the form: | 
|  | 634 | //    <id name="name"/> | 
|  | 635 | out_resource->value = util::make_unique<Id>(); | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 636 | } else if (!ref || ref->name.value().type.type != ResourceType::kId) { | 
| Ryan Mitchell | eaf77e1 | 2018-04-25 15:00:50 -0700 | [diff] [blame] | 637 | // If an inner element exists, the inner element must be a reference to another resource id | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 638 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 639 | << "<" << parser->element_name() | 
|  | 640 | << "> inner element must either be a resource reference or empty"); | 
| y | 9efbbef | 2018-04-18 11:29:09 -0700 | [diff] [blame] | 641 | return false; | 
|  | 642 | } | 
|  | 643 | } | 
|  | 644 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 645 | return true; | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 646 | } else if (resource_type == "macro") { | 
|  | 647 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 648 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 649 | << "<" << parser->element_name() << "> missing 'name' attribute"); | 
|  | 650 | return false; | 
|  | 651 | } | 
|  | 652 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 653 | out_resource->name.type = | 
|  | 654 | ResourceNamedTypeWithDefaultName(ResourceType::kMacro).ToResourceNamedType(); | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 655 | out_resource->name.entry = std::string(maybe_name.value()); | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 656 | return ParseMacro(parser, out_resource); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 657 | } | 
|  | 658 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 659 | if (can_be_item) { | 
|  | 660 | const auto item_iter = elToItemMap.find(resource_type); | 
|  | 661 | if (item_iter != elToItemMap.end()) { | 
|  | 662 | // This is an item, record its type and format and start parsing. | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 663 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 664 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 665 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 666 | << "<" << parser->element_name() << "> missing 'name' attribute"); | 
|  | 667 | return false; | 
|  | 668 | } | 
|  | 669 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 670 | out_resource->name.type = | 
|  | 671 | ResourceNamedTypeWithDefaultName(item_iter->second.type).ToResourceNamedType(); | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 672 | out_resource->name.entry = std::string(maybe_name.value()); | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 673 |  | 
| Adam Lesinski | e597d68 | 2017-06-01 17:16:44 -0700 | [diff] [blame] | 674 | // Only use the implied format of the type when there is no explicit format. | 
|  | 675 | if (resource_format == 0u) { | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 676 | resource_format = item_iter->second.format; | 
|  | 677 | } | 
|  | 678 |  | 
| Jeremy Meyer | 16c83af | 2024-07-26 16:21:49 -0700 | [diff] [blame] | 679 | if (!ParseItem(parser, out_resource, resource_format)) { | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 680 | return false; | 
|  | 681 | } | 
|  | 682 | return true; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 683 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 684 | } | 
|  | 685 |  | 
|  | 686 | // This might be a bag or something. | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 687 | if (can_be_bag) { | 
|  | 688 | const auto bag_iter = elToBagMap.find(resource_type); | 
|  | 689 | if (bag_iter != elToBagMap.end()) { | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 690 | // Ensure we have a name (unless this is a <public-group> or <overlayable>). | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 691 | if (resource_type != kPublicGroupTag && resource_type != kStagingPublicGroupTag && | 
| Ryan Mitchell | 2fedba9 | 2021-04-23 07:47:38 -0700 | [diff] [blame] | 692 | resource_type != kStagingPublicGroupFinalTag && resource_type != "overlayable") { | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 693 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 694 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 695 | << "<" << parser->element_name() << "> missing 'name' attribute"); | 
|  | 696 | return false; | 
|  | 697 | } | 
|  | 698 |  | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 699 | out_resource->name.entry = std::string(maybe_name.value()); | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 700 | } | 
|  | 701 |  | 
|  | 702 | // Call the associated parse method. The type will be filled in by the | 
|  | 703 | // parse func. | 
|  | 704 | if (!bag_iter->second(this, parser, out_resource)) { | 
|  | 705 | return false; | 
|  | 706 | } | 
|  | 707 | return true; | 
|  | 708 | } | 
|  | 709 | } | 
|  | 710 |  | 
|  | 711 | if (can_be_item) { | 
|  | 712 | // Try parsing the elementName (or type) as a resource. These shall only be | 
|  | 713 | // resources like 'layout' or 'xml' and they can only be references. | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 714 | std::optional<ResourceNamedTypeRef> parsed_type = ParseResourceNamedType(resource_type); | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 715 | if (parsed_type) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 716 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 717 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 718 | << "<" << parser->element_name() << "> missing 'name' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 719 | return false; | 
|  | 720 | } | 
|  | 721 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 722 | out_resource->name.type = parsed_type->ToResourceNamedType(); | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 723 | out_resource->name.entry = std::string(maybe_name.value()); | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 724 | out_resource->value = ParseXml(parser, android::ResTable_map::TYPE_REFERENCE, kNoRawString); | 
|  | 725 | if (!out_resource->value) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 726 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 727 | << "invalid value for type '" << *parsed_type << "'. Expected a reference"); | 
|  | 728 | return false; | 
|  | 729 | } | 
|  | 730 | return true; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 731 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 732 | } | 
|  | 733 |  | 
| Izabela Orlowska | a3ab21f | 2019-01-17 12:09:59 +0000 | [diff] [blame] | 734 | // If the resource type was not recognized, write the error and return false. | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 735 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 736 | << "unknown resource type '" << resource_type << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 737 | return false; | 
|  | 738 | } | 
|  | 739 |  | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 740 | std::optional<FeatureFlagAttribute> ResourceParser::GetFlag(xml::XmlPullParser* parser) { | 
|  | 741 | auto name = xml::FindAttribute(parser, xml::kSchemaAndroid, "featureFlag"); | 
|  | 742 | if (name) { | 
|  | 743 | FeatureFlagAttribute flag; | 
|  | 744 | if (name->starts_with('!')) { | 
|  | 745 | flag.negated = true; | 
|  | 746 | flag.name = name->substr(1); | 
|  | 747 | } else { | 
|  | 748 | flag.name = name.value(); | 
| Jeremy Meyer | d52bd68 | 2024-08-14 11:16:58 -0700 | [diff] [blame] | 749 | } | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 750 | return flag; | 
|  | 751 | } else { | 
|  | 752 | return {}; | 
| Jeremy Meyer | d52bd68 | 2024-08-14 11:16:58 -0700 | [diff] [blame] | 753 | } | 
| Jeremy Meyer | d52bd68 | 2024-08-14 11:16:58 -0700 | [diff] [blame] | 754 | } | 
|  | 755 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 756 | bool ResourceParser::ParseItem(xml::XmlPullParser* parser, | 
|  | 757 | ParsedResource* out_resource, | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 758 | const uint32_t format) { | 
|  | 759 | if (format == android::ResTable_map::TYPE_STRING) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 760 | return ParseString(parser, out_resource); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 761 | } | 
|  | 762 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 763 | out_resource->value = ParseXml(parser, format, kNoRawString); | 
|  | 764 | if (!out_resource->value) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 765 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 766 | << "invalid " << out_resource->name.type); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 767 | return false; | 
|  | 768 | } | 
|  | 769 | return true; | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 770 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 771 |  | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 772 | std::optional<FlattenedXmlSubTree> ResourceParser::CreateFlattenSubTree( | 
|  | 773 | xml::XmlPullParser* parser) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 774 | const size_t begin_xml_line = parser->line_number(); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 775 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 776 | std::string raw_value; | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 777 | android::StyleString style_string; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 778 | std::vector<UntranslatableSection> untranslatable_sections; | 
|  | 779 | if (!FlattenXmlSubtree(parser, &raw_value, &style_string, &untranslatable_sections)) { | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 780 | return {}; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 781 | } | 
|  | 782 |  | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 783 | return FlattenedXmlSubTree{.raw_value = raw_value, | 
|  | 784 | .style_string = style_string, | 
|  | 785 | .untranslatable_sections = untranslatable_sections, | 
|  | 786 | .namespace_resolver = parser, | 
|  | 787 | .source = source_.WithLine(begin_xml_line)}; | 
|  | 788 | } | 
|  | 789 |  | 
|  | 790 | /** | 
|  | 791 | * Reads the entire XML subtree and attempts to parse it as some Item, | 
|  | 792 | * with typeMask denoting which items it can be. If allowRawValue is | 
|  | 793 | * true, a RawString is returned if the XML couldn't be parsed as | 
|  | 794 | * an Item. If allowRawValue is false, nullptr is returned in this | 
|  | 795 | * case. | 
|  | 796 | */ | 
|  | 797 | std::unique_ptr<Item> ResourceParser::ParseXml(xml::XmlPullParser* parser, const uint32_t type_mask, | 
|  | 798 | const bool allow_raw_value) { | 
|  | 799 | auto sub_tree = CreateFlattenSubTree(parser); | 
|  | 800 | if (!sub_tree.has_value()) { | 
|  | 801 | return {}; | 
|  | 802 | } | 
|  | 803 | return ParseXml(sub_tree.value(), type_mask, allow_raw_value, *table_, config_, *diag_); | 
|  | 804 | } | 
|  | 805 |  | 
|  | 806 | std::unique_ptr<Item> ResourceParser::ParseXml(const FlattenedXmlSubTree& xmlsub_tree, | 
|  | 807 | const uint32_t type_mask, const bool allow_raw_value, | 
|  | 808 | ResourceTable& table, | 
|  | 809 | const android::ConfigDescription& config, | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 810 | android::IDiagnostics& diag) { | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 811 | if (!xmlsub_tree.style_string.spans.empty()) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 812 | // This can only be a StyledString. | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 813 | std::unique_ptr<StyledString> styled_string = | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 814 | util::make_unique<StyledString>(table.string_pool.MakeRef( | 
|  | 815 | xmlsub_tree.style_string, | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 816 | android::StringPool::Context(android::StringPool::Context::kNormalPriority, config))); | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 817 | styled_string->untranslatable_sections = xmlsub_tree.untranslatable_sections; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 818 | return std::move(styled_string); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 819 | } | 
|  | 820 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 821 | auto on_create_reference = [&](const ResourceName& name) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 822 | // name.package can be empty here, as it will assume the package name of the | 
|  | 823 | // table. | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 824 | auto id = util::make_unique<Id>(); | 
|  | 825 | id->SetSource(xmlsub_tree.source); | 
|  | 826 | return table.AddResource(NewResourceBuilder(name).SetValue(std::move(id)).Build(), &diag); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 827 | }; | 
|  | 828 |  | 
|  | 829 | // Process the raw value. | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 830 | std::unique_ptr<Item> processed_item = ResourceUtils::TryParseItemForAttribute( | 
| Brandon Liu | 48d229d | 2023-05-04 23:54:03 +0000 | [diff] [blame] | 831 | &diag, xmlsub_tree.raw_value, type_mask, on_create_reference); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 832 | if (processed_item) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 833 | // Fix up the reference. | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 834 | if (auto ref = ValueCast<Reference>(processed_item.get())) { | 
|  | 835 | ref->allow_raw = allow_raw_value; | 
|  | 836 | ResolvePackage(xmlsub_tree.namespace_resolver, ref); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 837 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 838 | return processed_item; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 839 | } | 
|  | 840 |  | 
|  | 841 | // Try making a regular string. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 842 | if (type_mask & android::ResTable_map::TYPE_STRING) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 843 | // Use the trimmed, escaped string. | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 844 | std::unique_ptr<String> string = util::make_unique<String>(table.string_pool.MakeRef( | 
|  | 845 | xmlsub_tree.style_string.str, android::StringPool::Context(config))); | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 846 | string->untranslatable_sections = xmlsub_tree.untranslatable_sections; | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 847 | return std::move(string); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 848 | } | 
|  | 849 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 850 | if (allow_raw_value) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 851 | // We can't parse this so return a RawString if we are allowed. | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 852 | return util::make_unique<RawString>(table.string_pool.MakeRef( | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 853 | util::TrimWhitespace(xmlsub_tree.raw_value), android::StringPool::Context(config))); | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 854 | } else if (util::TrimWhitespace(xmlsub_tree.raw_value).empty()) { | 
| Ryan Mitchell | fc3874a | 2019-05-28 16:30:17 -0700 | [diff] [blame] | 855 | // If the text is empty, and the value is not allowed to be a string, encode it as a @null. | 
|  | 856 | return ResourceUtils::MakeNull(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 857 | } | 
|  | 858 | return {}; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 859 | } | 
|  | 860 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 861 | bool ResourceParser::ParseString(xml::XmlPullParser* parser, | 
|  | 862 | ParsedResource* out_resource) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 863 | bool formatted = true; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 864 | if (std::optional<StringPiece> formatted_attr = xml::FindAttribute(parser, "formatted")) { | 
|  | 865 | std::optional<bool> maybe_formatted = ResourceUtils::ParseBool(formatted_attr.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 866 | if (!maybe_formatted) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 867 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 868 | << "invalid value for 'formatted'. Must be a boolean"); | 
|  | 869 | return false; | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 870 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 871 | formatted = maybe_formatted.value(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 872 | } | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 873 |  | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 874 | bool translatable = options_.translatable; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 875 | if (std::optional<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) { | 
|  | 876 | std::optional<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value()); | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 877 | if (!maybe_translatable) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 878 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 879 | << "invalid value for 'translatable'. Must be a boolean"); | 
|  | 880 | return false; | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 881 | } | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 882 | translatable = maybe_translatable.value(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 883 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 884 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 885 | out_resource->value = | 
|  | 886 | ParseXml(parser, android::ResTable_map::TYPE_STRING, kNoRawString); | 
|  | 887 | if (!out_resource->value) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 888 | diag_->Error(android::DiagMessage(out_resource->source) << "not a valid string"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 889 | return false; | 
|  | 890 | } | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 891 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 892 | if (String* string_value = ValueCast<String>(out_resource->value.get())) { | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 893 | string_value->SetTranslatable(translatable); | 
| Adam Lesinski | 393b5f0 | 2015-12-17 13:03:11 -0800 | [diff] [blame] | 894 |  | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 895 | if (formatted && translatable) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 896 | if (!util::VerifyJavaStringFormat(*string_value->value)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 897 | android::DiagMessage msg(out_resource->source); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 898 | msg << "multiple substitutions specified in non-positional format; " | 
|  | 899 | "did you mean to add the formatted=\"false\" attribute?"; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 900 | if (options_.error_on_positional_arguments) { | 
|  | 901 | diag_->Error(msg); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 902 | return false; | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 903 | } | 
| Adam Lesinski | 393b5f0 | 2015-12-17 13:03:11 -0800 | [diff] [blame] | 904 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 905 | diag_->Warn(msg); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 906 | } | 
| Adam Lesinski | b23f1e0 | 2015-11-03 12:24:17 -0800 | [diff] [blame] | 907 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 908 |  | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 909 | } else if (StyledString* string_value = ValueCast<StyledString>(out_resource->value.get())) { | 
|  | 910 | string_value->SetTranslatable(translatable); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 911 | } | 
|  | 912 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 913 | } | 
|  | 914 |  | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 915 | bool ResourceParser::ParseMacro(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 916 | auto sub_tree = CreateFlattenSubTree(parser); | 
|  | 917 | if (!sub_tree) { | 
|  | 918 | return false; | 
|  | 919 | } | 
|  | 920 |  | 
|  | 921 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 922 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 923 | << "<macro> tags cannot be declared in configurations other than the default " | 
|  | 924 | "configuration'"); | 
|  | 925 | return false; | 
|  | 926 | } | 
|  | 927 |  | 
|  | 928 | auto macro = std::make_unique<Macro>(); | 
|  | 929 | macro->raw_value = std::move(sub_tree->raw_value); | 
|  | 930 | macro->style_string = std::move(sub_tree->style_string); | 
|  | 931 | macro->untranslatable_sections = std::move(sub_tree->untranslatable_sections); | 
|  | 932 |  | 
|  | 933 | for (const auto& decl : parser->package_decls()) { | 
|  | 934 | macro->alias_namespaces.emplace_back( | 
|  | 935 | Macro::Namespace{.alias = decl.prefix, | 
|  | 936 | .package_name = decl.package.package, | 
|  | 937 | .is_private = decl.package.private_namespace}); | 
|  | 938 | } | 
|  | 939 |  | 
|  | 940 | out_resource->value = std::move(macro); | 
|  | 941 | return true; | 
|  | 942 | } | 
|  | 943 |  | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 944 | bool ResourceParser::ParsePublic(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 945 | if (options_.visibility) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 946 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 947 | << "<public> tag not allowed with --visibility flag"); | 
|  | 948 | return false; | 
|  | 949 | } | 
|  | 950 |  | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 951 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 952 | diag_->Warn(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 953 | << "ignoring configuration '" << out_resource->config << "' for <public> tag"); | 
|  | 954 | } | 
|  | 955 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 956 | std::optional<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 957 | if (!maybe_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 958 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 959 | << "<public> must have a 'type' attribute"); | 
|  | 960 | return false; | 
|  | 961 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 962 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 963 | std::optional<ResourceNamedTypeRef> parsed_type = ParseResourceNamedType(maybe_type.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 964 | if (!parsed_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 965 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 966 | << "invalid resource type '" << maybe_type.value() << "' in <public>"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 967 | return false; | 
|  | 968 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 969 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 970 | out_resource->name.type = parsed_type->ToResourceNamedType(); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 971 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 972 | if (std::optional<StringPiece> maybe_id_str = xml::FindNonEmptyAttribute(parser, "id")) { | 
|  | 973 | std::optional<ResourceId> maybe_id = ResourceUtils::ParseResourceId(maybe_id_str.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 974 | if (!maybe_id) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 975 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 976 | << "invalid resource ID '" << maybe_id_str.value() << "' in <public>"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 977 | return false; | 
| Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 978 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 979 | out_resource->id = maybe_id.value(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 980 | } | 
| Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 981 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 982 | if (parsed_type->type == ResourceType::kId) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 983 | // An ID marked as public is also the definition of an ID. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 984 | out_resource->value = util::make_unique<Id>(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 985 | } | 
| Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 986 |  | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 987 | out_resource->visibility_level = Visibility::Level::kPublic; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 988 | return true; | 
| Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 989 | } | 
|  | 990 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 991 | template <typename Func> | 
|  | 992 | bool static ParseGroupImpl(xml::XmlPullParser* parser, ParsedResource* out_resource, | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 993 | const char* tag_name, android::IDiagnostics* diag, Func&& func) { | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 994 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 995 | diag->Warn(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 996 | << "ignoring configuration '" << out_resource->config << "' for <" << tag_name | 
|  | 997 | << "> tag"); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 998 | } | 
|  | 999 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1000 | std::optional<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1001 | if (!maybe_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1002 | diag->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1003 | << "<" << tag_name << "> must have a 'type' attribute"); | 
| Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 1004 | return false; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1005 | } | 
| Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 1006 |  | 
| Iurii Makhno | aeac0d0 | 2022-02-22 06:41:58 +0000 | [diff] [blame] | 1007 | std::optional<ResourceNamedTypeRef> maybe_parsed_type = | 
|  | 1008 | ParseResourceNamedType(maybe_type.value()); | 
|  | 1009 | if (!maybe_parsed_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1010 | diag->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1011 | << "invalid resource type '" << maybe_type.value() << "' in <" << tag_name << ">"); | 
| Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 1012 | return false; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1013 | } | 
| Iurii Makhno | aeac0d0 | 2022-02-22 06:41:58 +0000 | [diff] [blame] | 1014 | auto parsed_type = maybe_parsed_type->ToResourceNamedType(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1015 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1016 | std::optional<StringPiece> maybe_id_str = xml::FindNonEmptyAttribute(parser, "first-id"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1017 | if (!maybe_id_str) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1018 | diag->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1019 | << "<" << tag_name << "> must have a 'first-id' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1020 | return false; | 
|  | 1021 | } | 
|  | 1022 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1023 | std::optional<ResourceId> maybe_id = ResourceUtils::ParseResourceId(maybe_id_str.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1024 | if (!maybe_id) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1025 | diag->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1026 | << "invalid resource ID '" << maybe_id_str.value() << "' in <" << tag_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1027 | return false; | 
|  | 1028 | } | 
|  | 1029 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1030 | std::string comment; | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1031 | ResourceId next_id = maybe_id.value(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1032 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1033 | const size_t depth = parser->depth(); | 
|  | 1034 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1035 | if (parser->event() == xml::XmlPullParser::Event::kComment) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1036 | comment = std::string(util::TrimWhitespace(parser->comment())); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1037 | continue; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1038 | } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1039 | // Skip text. | 
|  | 1040 | continue; | 
|  | 1041 | } | 
|  | 1042 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1043 | const android::Source item_source = out_resource->source.WithLine(parser->line_number()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1044 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1045 | const std::string& element_name = parser->element_name(); | 
|  | 1046 | if (element_namespace.empty() && element_name == "public") { | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1047 | auto maybe_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1048 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1049 | diag->Error(android::DiagMessage(item_source) << "<public> must have a 'name' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1050 | error = true; | 
|  | 1051 | continue; | 
|  | 1052 | } | 
|  | 1053 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1054 | if (xml::FindNonEmptyAttribute(parser, "id")) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1055 | diag->Error(android::DiagMessage(item_source) | 
|  | 1056 | << "'id' is ignored within <" << tag_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1057 | error = true; | 
|  | 1058 | continue; | 
|  | 1059 | } | 
|  | 1060 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1061 | if (xml::FindNonEmptyAttribute(parser, "type")) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1062 | diag->Error(android::DiagMessage(item_source) | 
|  | 1063 | << "'type' is ignored within <" << tag_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1064 | error = true; | 
|  | 1065 | continue; | 
|  | 1066 | } | 
|  | 1067 |  | 
| Winson Chiu | c84829d | 2022-03-04 20:35:58 +0000 | [diff] [blame] | 1068 | if (maybe_name.value().substr(0, std::strlen("removed_")) == "removed_") { | 
|  | 1069 | // Skip resources that have been removed from the framework, but leave a hole so that | 
|  | 1070 | // other staged resources don't shift and break apps previously compiled against them | 
|  | 1071 | next_id.id++; | 
|  | 1072 | continue; | 
|  | 1073 | } | 
|  | 1074 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1075 | ParsedResource& entry_res = out_resource->child_resources.emplace_back(ParsedResource{ | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1076 | .name = ResourceName{{}, parsed_type, std::string(maybe_name.value())}, | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1077 | .source = item_source, | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1078 | .comment = std::move(comment), | 
|  | 1079 | }); | 
| Felka Chang | 5cf069b | 2021-10-27 00:06:04 +0800 | [diff] [blame] | 1080 | comment.clear(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1081 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1082 | // Execute group specific code. | 
|  | 1083 | func(entry_res, next_id); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1084 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1085 | next_id.id++; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1086 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1087 | diag->Error(android::DiagMessage(item_source) << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1088 | error = true; | 
|  | 1089 | } | 
|  | 1090 | } | 
|  | 1091 | return !error; | 
| Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 1092 | } | 
|  | 1093 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1094 | bool ResourceParser::ParseStagingPublicGroup(xml::XmlPullParser* parser, | 
|  | 1095 | ParsedResource* out_resource) { | 
|  | 1096 | return ParseGroupImpl(parser, out_resource, kStagingPublicGroupTag, diag_, | 
|  | 1097 | [](ParsedResource& parsed_entry, ResourceId id) { | 
|  | 1098 | parsed_entry.id = id; | 
|  | 1099 | parsed_entry.staged_api = true; | 
|  | 1100 | parsed_entry.visibility_level = Visibility::Level::kPublic; | 
|  | 1101 | }); | 
|  | 1102 | } | 
|  | 1103 |  | 
| Ryan Mitchell | 2fedba9 | 2021-04-23 07:47:38 -0700 | [diff] [blame] | 1104 | bool ResourceParser::ParseStagingPublicGroupFinal(xml::XmlPullParser* parser, | 
|  | 1105 | ParsedResource* out_resource) { | 
|  | 1106 | return ParseGroupImpl(parser, out_resource, kStagingPublicGroupFinalTag, diag_, | 
|  | 1107 | [](ParsedResource& parsed_entry, ResourceId id) { | 
|  | 1108 | parsed_entry.staged_alias = StagedId{id, parsed_entry.source}; | 
|  | 1109 | }); | 
|  | 1110 | } | 
|  | 1111 |  | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1112 | bool ResourceParser::ParsePublicGroup(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 1113 | if (options_.visibility) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1114 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 2e9bec1 | 2021-03-22 09:31:00 -0700 | [diff] [blame] | 1115 | << "<" << kPublicGroupTag << "> tag not allowed with --visibility flag"); | 
|  | 1116 | return false; | 
|  | 1117 | } | 
|  | 1118 |  | 
|  | 1119 | return ParseGroupImpl(parser, out_resource, kPublicGroupTag, diag_, | 
|  | 1120 | [](ParsedResource& parsed_entry, ResourceId id) { | 
|  | 1121 | parsed_entry.id = id; | 
|  | 1122 | parsed_entry.visibility_level = Visibility::Level::kPublic; | 
|  | 1123 | }); | 
|  | 1124 | } | 
|  | 1125 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1126 | bool ResourceParser::ParseSymbolImpl(xml::XmlPullParser* parser, | 
|  | 1127 | ParsedResource* out_resource) { | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1128 | std::optional<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1129 | if (!maybe_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1130 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 1131 | << "<" << parser->element_name() << "> must have a 'type' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1132 | return false; | 
|  | 1133 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1134 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1135 | std::optional<ResourceNamedTypeRef> parsed_type = ParseResourceNamedType(maybe_type.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1136 | if (!parsed_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1137 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1138 | << "invalid resource type '" << maybe_type.value() << "' in <" | 
|  | 1139 | << parser->element_name() << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1140 | return false; | 
|  | 1141 | } | 
|  | 1142 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1143 | out_resource->name.type = parsed_type->ToResourceNamedType(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1144 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1145 | } | 
|  | 1146 |  | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1147 | bool ResourceParser::ParseSymbol(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 1148 | if (options_.visibility) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1149 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 1150 | << "<java-symbol> and <symbol> tags not allowed with --visibility flag"); | 
|  | 1151 | return false; | 
|  | 1152 | } | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1153 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1154 | diag_->Warn(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1155 | << "ignoring configuration '" << out_resource->config << "' for <" | 
|  | 1156 | << parser->element_name() << "> tag"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1157 | } | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1158 |  | 
|  | 1159 | if (!ParseSymbolImpl(parser, out_resource)) { | 
|  | 1160 | return false; | 
|  | 1161 | } | 
|  | 1162 |  | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 1163 | out_resource->visibility_level = Visibility::Level::kPrivate; | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1164 | return true; | 
|  | 1165 | } | 
|  | 1166 |  | 
|  | 1167 | bool ResourceParser::ParseOverlayable(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 1168 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1169 | diag_->Warn(android::DiagMessage(out_resource->source) | 
|  | 1170 | << "ignoring configuration '" << out_resource->config << "' for <overlayable> tag"); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1171 | } | 
|  | 1172 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1173 | std::optional<StringPiece> overlayable_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1174 | if (!overlayable_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1175 | diag_->Error(android::DiagMessage(out_resource->source) | 
|  | 1176 | << "<overlayable> tag must have a 'name' attribute"); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1177 | return false; | 
|  | 1178 | } | 
|  | 1179 |  | 
|  | 1180 | const std::string kActorUriScheme = | 
|  | 1181 | android::base::StringPrintf("%s://", Overlayable::kActorScheme); | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1182 | std::optional<StringPiece> overlayable_actor = xml::FindNonEmptyAttribute(parser, "actor"); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1183 | if (overlayable_actor && !util::StartsWith(overlayable_actor.value(), kActorUriScheme)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1184 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1185 | << "specified <overlayable> tag 'actor' attribute must use the scheme '" | 
|  | 1186 | << Overlayable::kActorScheme << "'"); | 
|  | 1187 | return false; | 
|  | 1188 | } | 
|  | 1189 |  | 
|  | 1190 | // Create a overlayable entry grouping that represents this <overlayable> | 
|  | 1191 | auto overlayable = std::make_shared<Overlayable>( | 
|  | 1192 | overlayable_name.value(), (overlayable_actor) ? overlayable_actor.value() : "", | 
| Ryan Mitchell | b5b162b | 2019-02-07 20:07:21 -0800 | [diff] [blame] | 1193 | source_); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1194 |  | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1195 | bool error = false; | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1196 | std::string comment; | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 1197 | PolicyFlags current_policies = PolicyFlags::NONE; | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1198 | const size_t start_depth = parser->depth(); | 
|  | 1199 | while (xml::XmlPullParser::IsGoodEvent(parser->Next())) { | 
|  | 1200 | xml::XmlPullParser::Event event = parser->event(); | 
|  | 1201 | if (event == xml::XmlPullParser::Event::kEndElement && parser->depth() == start_depth) { | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1202 | // Break the loop when exiting the <overlayable> | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1203 | break; | 
|  | 1204 | } else if (event == xml::XmlPullParser::Event::kEndElement | 
|  | 1205 | && parser->depth() == start_depth + 1) { | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1206 | // Clear the current policies when exiting the <policy> tags | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 1207 | current_policies = PolicyFlags::NONE; | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1208 | continue; | 
|  | 1209 | } else if (event == xml::XmlPullParser::Event::kComment) { | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1210 | // Retrieve the comment of individual <item> tags | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1211 | comment = parser->comment(); | 
|  | 1212 | continue; | 
|  | 1213 | } else if (event != xml::XmlPullParser::Event::kStartElement) { | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1214 | // Skip to the start of the next element | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1215 | continue; | 
|  | 1216 | } | 
|  | 1217 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1218 | const android::Source element_source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1219 | const std::string& element_name = parser->element_name(); | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1220 | const std::string& element_namespace = parser->element_namespace(); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1221 | if (element_namespace.empty() && element_name == "item") { | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 1222 | if (current_policies == PolicyFlags::NONE) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1223 | diag_->Error(android::DiagMessage(element_source) | 
|  | 1224 | << "<item> within an <overlayable> must be inside a <policy> block"); | 
| Winson | b2d7f53 | 2019-02-04 16:32:43 -0800 | [diff] [blame] | 1225 | error = true; | 
|  | 1226 | continue; | 
|  | 1227 | } | 
|  | 1228 |  | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1229 | // Items specify the name and type of resource that should be overlayable | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1230 | std::optional<StringPiece> item_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1231 | if (!item_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1232 | diag_->Error(android::DiagMessage(element_source) | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1233 | << "<item> within an <overlayable> must have a 'name' attribute"); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1234 | error = true; | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1235 | continue; | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1236 | } | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1237 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1238 | std::optional<StringPiece> item_type = xml::FindNonEmptyAttribute(parser, "type"); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1239 | if (!item_type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1240 | diag_->Error(android::DiagMessage(element_source) | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1241 | << "<item> within an <overlayable> must have a 'type' attribute"); | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1242 | error = true; | 
|  | 1243 | continue; | 
|  | 1244 | } | 
|  | 1245 |  | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1246 | std::optional<ResourceNamedTypeRef> type = ParseResourceNamedType(item_type.value()); | 
|  | 1247 | if (!type) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1248 | diag_->Error(android::DiagMessage(element_source) | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1249 | << "invalid resource type '" << item_type.value() | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1250 | << "' in <item> within an <overlayable>"); | 
|  | 1251 | error = true; | 
|  | 1252 | continue; | 
|  | 1253 | } | 
|  | 1254 |  | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1255 | OverlayableItem overlayable_item(overlayable); | 
|  | 1256 | overlayable_item.policies = current_policies; | 
|  | 1257 | overlayable_item.comment = comment; | 
|  | 1258 | overlayable_item.source = element_source; | 
|  | 1259 |  | 
|  | 1260 | ParsedResource child_resource{}; | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1261 | child_resource.name.type = type->ToResourceNamedType(); | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1262 | child_resource.name.entry = std::string(item_name.value()); | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1263 | child_resource.overlayable_item = overlayable_item; | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1264 | out_resource->child_resources.push_back(std::move(child_resource)); | 
|  | 1265 |  | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1266 | } else if (element_namespace.empty() && element_name == "policy") { | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 1267 | if (current_policies != PolicyFlags::NONE) { | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1268 | // If the policy list is not empty, then we are currently inside a policy element | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1269 | diag_->Error(android::DiagMessage(element_source) | 
|  | 1270 | << "<policy> blocks cannot be recursively nested"); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1271 | error = true; | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1272 | break; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1273 | } else if (std::optional<StringPiece> maybe_type = | 
|  | 1274 | xml::FindNonEmptyAttribute(parser, "type")) { | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1275 | // Parse the polices separated by vertical bar characters to allow for specifying multiple | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1276 | // policies. Items within the policy tag will have the specified policy. | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1277 | for (StringPiece part : util::Tokenize(maybe_type.value(), '|')) { | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1278 | StringPiece trimmed_part = util::TrimWhitespace(part); | 
| Winson | 62ac8b5 | 2019-12-04 08:36:48 -0800 | [diff] [blame] | 1279 | const auto policy = std::find_if(kPolicyStringToFlag.begin(), | 
|  | 1280 | kPolicyStringToFlag.end(), | 
|  | 1281 | [trimmed_part](const auto& it) { | 
|  | 1282 | return trimmed_part == it.first; | 
|  | 1283 | }); | 
|  | 1284 | if (policy == kPolicyStringToFlag.end()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1285 | diag_->Error(android::DiagMessage(element_source) | 
| Ryan Mitchell | 1bb1fe0 | 2018-11-16 11:21:41 -0800 | [diff] [blame] | 1286 | << "<policy> has unsupported type '" << trimmed_part << "'"); | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1287 | error = true; | 
|  | 1288 | continue; | 
|  | 1289 | } | 
| Ryan Mitchell | 939df09 | 2019-04-09 17:13:50 -0700 | [diff] [blame] | 1290 |  | 
|  | 1291 | current_policies |= policy->second; | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1292 | } | 
| Winson | b2d7f53 | 2019-02-04 16:32:43 -0800 | [diff] [blame] | 1293 | } else { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1294 | diag_->Error(android::DiagMessage(element_source) | 
| Ryan Mitchell | 939df09 | 2019-04-09 17:13:50 -0700 | [diff] [blame] | 1295 | << "<policy> must have a 'type' attribute"); | 
| Winson | b2d7f53 | 2019-02-04 16:32:43 -0800 | [diff] [blame] | 1296 | error = true; | 
|  | 1297 | continue; | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1298 | } | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1299 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1300 | diag_->Error(android::DiagMessage(element_source) | 
|  | 1301 | << "invalid element <" << element_name << "> " | 
|  | 1302 | << " in <overlayable>"); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1303 | error = true; | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1304 | break; | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1305 | } | 
| Ryan Mitchell | 54237ff | 2018-12-13 15:44:29 -0800 | [diff] [blame] | 1306 |  | 
|  | 1307 | comment.clear(); | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1308 | } | 
| Ryan Mitchell | e4e989c | 2018-10-29 02:21:50 -0700 | [diff] [blame] | 1309 |  | 
| Adam Lesinski | 46c4d72 | 2017-08-23 13:03:56 -0700 | [diff] [blame] | 1310 | return !error; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1311 | } | 
|  | 1312 |  | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 1313 | bool ResourceParser::ParseAddResource(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1314 | if (ParseSymbolImpl(parser, out_resource)) { | 
| Adam Lesinski | 71be705 | 2017-12-12 16:48:07 -0800 | [diff] [blame] | 1315 | out_resource->visibility_level = Visibility::Level::kUndefined; | 
| Adam Lesinski | 4488f1c | 2017-05-26 17:33:38 -0700 | [diff] [blame] | 1316 | out_resource->allow_new = true; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1317 | return true; | 
|  | 1318 | } | 
|  | 1319 | return false; | 
|  | 1320 | } | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1321 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1322 | bool ResourceParser::ParseAttr(xml::XmlPullParser* parser, | 
|  | 1323 | ParsedResource* out_resource) { | 
|  | 1324 | return ParseAttrImpl(parser, out_resource, false); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1325 | } | 
|  | 1326 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1327 | bool ResourceParser::ParseAttrImpl(xml::XmlPullParser* parser, | 
|  | 1328 | ParsedResource* out_resource, bool weak) { | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1329 | out_resource->name.type = | 
|  | 1330 | ResourceNamedTypeWithDefaultName(ResourceType::kAttr).ToResourceNamedType(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1331 |  | 
|  | 1332 | // Attributes only end up in default configuration. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1333 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1334 | diag_->Warn(android::DiagMessage(out_resource->source) | 
|  | 1335 | << "ignoring configuration '" << out_resource->config << "' for attribute " | 
|  | 1336 | << out_resource->name); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1337 | out_resource->config = ConfigDescription::DefaultConfig(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1338 | } | 
|  | 1339 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1340 | uint32_t type_mask = 0; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1341 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1342 | std::optional<StringPiece> maybe_format = xml::FindAttribute(parser, "format"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1343 | if (maybe_format) { | 
|  | 1344 | type_mask = ParseFormatAttribute(maybe_format.value()); | 
|  | 1345 | if (type_mask == 0) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1346 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 1347 | << "invalid attribute format '" << maybe_format.value() << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1348 | return false; | 
|  | 1349 | } | 
|  | 1350 | } | 
|  | 1351 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1352 | std::optional<int32_t> maybe_min, maybe_max; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1353 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1354 | if (std::optional<StringPiece> maybe_min_str = xml::FindAttribute(parser, "min")) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1355 | StringPiece min_str = util::TrimWhitespace(maybe_min_str.value()); | 
|  | 1356 | if (!min_str.empty()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1357 | std::u16string min_str16 = android::util::Utf8ToUtf16(min_str); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1358 | android::Res_value value; | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 1359 | if (android::ResTable::stringToInt(min_str16.data(), min_str16.size(), &value)) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1360 | maybe_min = static_cast<int32_t>(value.data); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1361 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1362 | } | 
|  | 1363 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1364 | if (!maybe_min) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1365 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1366 | << "invalid 'min' value '" << min_str << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1367 | return false; | 
|  | 1368 | } | 
|  | 1369 | } | 
|  | 1370 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1371 | if (std::optional<StringPiece> maybe_max_str = xml::FindAttribute(parser, "max")) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1372 | StringPiece max_str = util::TrimWhitespace(maybe_max_str.value()); | 
|  | 1373 | if (!max_str.empty()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1374 | std::u16string max_str16 = android::util::Utf8ToUtf16(max_str); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1375 | android::Res_value value; | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 1376 | if (android::ResTable::stringToInt(max_str16.data(), max_str16.size(), &value)) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1377 | maybe_max = static_cast<int32_t>(value.data); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1378 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1379 | } | 
|  | 1380 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1381 | if (!maybe_max) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1382 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1383 | << "invalid 'max' value '" << max_str << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1384 | return false; | 
|  | 1385 | } | 
|  | 1386 | } | 
|  | 1387 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1388 | if ((maybe_min || maybe_max) && | 
|  | 1389 | (type_mask & android::ResTable_map::TYPE_INTEGER) == 0) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1390 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1391 | << "'min' and 'max' can only be used when format='integer'"); | 
|  | 1392 | return false; | 
|  | 1393 | } | 
|  | 1394 |  | 
|  | 1395 | struct SymbolComparator { | 
| Yi Kong | 087e2d4 | 2017-05-02 12:49:25 -0700 | [diff] [blame] | 1396 | bool operator()(const Attribute::Symbol& a, const Attribute::Symbol& b) const { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1397 | return a.symbol.name.value() < b.symbol.name.value(); | 
|  | 1398 | } | 
|  | 1399 | }; | 
|  | 1400 |  | 
|  | 1401 | std::set<Attribute::Symbol, SymbolComparator> items; | 
|  | 1402 |  | 
|  | 1403 | std::string comment; | 
|  | 1404 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1405 | const size_t depth = parser->depth(); | 
|  | 1406 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1407 | if (parser->event() == xml::XmlPullParser::Event::kComment) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1408 | comment = std::string(util::TrimWhitespace(parser->comment())); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1409 | continue; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1410 | } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1411 | // Skip text. | 
|  | 1412 | continue; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1413 | } | 
|  | 1414 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1415 | const android::Source item_source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1416 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1417 | const std::string& element_name = parser->element_name(); | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 1418 | if (element_namespace.empty() && (element_name == "flag" || element_name == "enum")) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1419 | if (element_name == "enum") { | 
|  | 1420 | if (type_mask & android::ResTable_map::TYPE_FLAGS) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1421 | diag_->Error(android::DiagMessage(item_source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1422 | << "can not define an <enum>; already defined a <flag>"); | 
|  | 1423 | error = true; | 
|  | 1424 | continue; | 
|  | 1425 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1426 | type_mask |= android::ResTable_map::TYPE_ENUM; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1427 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1428 | } else if (element_name == "flag") { | 
|  | 1429 | if (type_mask & android::ResTable_map::TYPE_ENUM) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1430 | diag_->Error(android::DiagMessage(item_source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1431 | << "can not define a <flag>; already defined an <enum>"); | 
|  | 1432 | error = true; | 
|  | 1433 | continue; | 
|  | 1434 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1435 | type_mask |= android::ResTable_map::TYPE_FLAGS; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1436 | } | 
|  | 1437 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1438 | if (std::optional<Attribute::Symbol> s = ParseEnumOrFlagItem(parser, element_name)) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1439 | Attribute::Symbol& symbol = s.value(); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1440 | ParsedResource child_resource; | 
|  | 1441 | child_resource.name = symbol.symbol.name.value(); | 
|  | 1442 | child_resource.source = item_source; | 
|  | 1443 | child_resource.value = util::make_unique<Id>(); | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 1444 | if (options_.visibility) { | 
|  | 1445 | child_resource.visibility_level = options_.visibility.value(); | 
|  | 1446 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1447 | out_resource->child_resources.push_back(std::move(child_resource)); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1448 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1449 | symbol.symbol.SetComment(std::move(comment)); | 
|  | 1450 | symbol.symbol.SetSource(item_source); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1451 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1452 | auto insert_result = items.insert(std::move(symbol)); | 
|  | 1453 | if (!insert_result.second) { | 
|  | 1454 | const Attribute::Symbol& existing_symbol = *insert_result.first; | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1455 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1456 | << "duplicate symbol '" << existing_symbol.symbol.name.value().entry << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1457 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1458 | diag_->Note(android::DiagMessage(existing_symbol.symbol.GetSource()) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1459 | << "first defined here"); | 
|  | 1460 | error = true; | 
|  | 1461 | } | 
|  | 1462 | } else { | 
|  | 1463 | error = true; | 
|  | 1464 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1465 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1466 | diag_->Error(android::DiagMessage(item_source) << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1467 | error = true; | 
|  | 1468 | } | 
|  | 1469 |  | 
|  | 1470 | comment = {}; | 
|  | 1471 | } | 
|  | 1472 |  | 
|  | 1473 | if (error) { | 
|  | 1474 | return false; | 
|  | 1475 | } | 
|  | 1476 |  | 
| Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 1477 | std::unique_ptr<Attribute> attr = util::make_unique<Attribute>( | 
|  | 1478 | type_mask ? type_mask : uint32_t{android::ResTable_map::TYPE_ANY}); | 
|  | 1479 | attr->SetWeak(weak); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1480 | attr->symbols = std::vector<Attribute::Symbol>(items.begin(), items.end()); | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1481 | attr->min_int = maybe_min.value_or(std::numeric_limits<int32_t>::min()); | 
|  | 1482 | attr->max_int = maybe_max.value_or(std::numeric_limits<int32_t>::max()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1483 | out_resource->value = std::move(attr); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1484 | return true; | 
|  | 1485 | } | 
|  | 1486 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1487 | std::optional<Attribute::Symbol> ResourceParser::ParseEnumOrFlagItem(xml::XmlPullParser* parser, | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1488 | StringPiece tag) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1489 | const android::Source source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1490 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1491 | std::optional<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1492 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1493 | diag_->Error(android::DiagMessage(source) | 
|  | 1494 | << "no attribute 'name' found for tag <" << tag << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1495 | return {}; | 
|  | 1496 | } | 
|  | 1497 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1498 | std::optional<StringPiece> maybe_value = xml::FindNonEmptyAttribute(parser, "value"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1499 | if (!maybe_value) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1500 | diag_->Error(android::DiagMessage(source) | 
|  | 1501 | << "no attribute 'value' found for tag <" << tag << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1502 | return {}; | 
|  | 1503 | } | 
|  | 1504 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1505 | std::u16string value16 = android::util::Utf8ToUtf16(maybe_value.value()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1506 | android::Res_value val; | 
|  | 1507 | if (!android::ResTable::stringToInt(value16.data(), value16.size(), &val)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1508 | diag_->Error(android::DiagMessage(source) << "invalid value '" << maybe_value.value() | 
|  | 1509 | << "' for <" << tag << ">; must be an integer"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1510 | return {}; | 
|  | 1511 | } | 
|  | 1512 |  | 
|  | 1513 | return Attribute::Symbol{ | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1514 | Reference(ResourceNameRef({}, ResourceNamedTypeWithDefaultName(ResourceType::kId), | 
|  | 1515 | maybe_name.value())), | 
| Ryan Mitchell | c167680 | 2019-05-20 16:47:08 -0700 | [diff] [blame] | 1516 | val.data, val.dataType}; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1517 | } | 
|  | 1518 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1519 | bool ResourceParser::ParseStyleItem(xml::XmlPullParser* parser, Style* style) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1520 | const android::Source source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1521 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1522 | std::optional<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1523 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1524 | diag_->Error(android::DiagMessage(source) << "<item> must have a 'name' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1525 | return false; | 
|  | 1526 | } | 
|  | 1527 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1528 | std::optional<Reference> maybe_key = ResourceUtils::ParseXmlAttributeName(maybe_name.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1529 | if (!maybe_key) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1530 | diag_->Error(android::DiagMessage(source) | 
|  | 1531 | << "invalid attribute name '" << maybe_name.value() << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1532 | return false; | 
|  | 1533 | } | 
|  | 1534 |  | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1535 | ResolvePackage(parser, &maybe_key.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1536 | maybe_key.value().SetSource(source); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1537 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1538 | std::unique_ptr<Item> value = ParseXml(parser, 0, kAllowRawString); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1539 | if (!value) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1540 | diag_->Error(android::DiagMessage(source) << "could not parse style item"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1541 | return false; | 
|  | 1542 | } | 
|  | 1543 |  | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1544 | style->entries.push_back(Style::Entry{std::move(maybe_key.value()), std::move(value)}); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1545 | return true; | 
|  | 1546 | } | 
|  | 1547 |  | 
| Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 1548 | bool ResourceParser::ParseStyle(const ResourceType type, xml::XmlPullParser* parser, | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1549 | ParsedResource* out_resource) { | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1550 | out_resource->name.type = ResourceNamedTypeWithDefaultName(type).ToResourceNamedType(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1551 |  | 
|  | 1552 | std::unique_ptr<Style> style = util::make_unique<Style>(); | 
|  | 1553 |  | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1554 | std::optional<StringPiece> maybe_parent = xml::FindAttribute(parser, "parent"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1555 | if (maybe_parent) { | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1556 | // If the parent is empty, we don't have a parent, but we also don't infer either. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1557 | if (!maybe_parent.value().empty()) { | 
|  | 1558 | std::string err_str; | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1559 | style->parent = ResourceUtils::ParseStyleParentReference(maybe_parent.value(), &err_str); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1560 | if (!style->parent) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1561 | diag_->Error(android::DiagMessage(out_resource->source) << err_str); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1562 | return false; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1563 | } | 
|  | 1564 |  | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1565 | // Transform the namespace prefix to the actual package name, and mark the reference as | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1566 | // private if appropriate. | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1567 | ResolvePackage(parser, &style->parent.value()); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1568 | } | 
|  | 1569 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1570 | } else { | 
|  | 1571 | // No parent was specified, so try inferring it from the style name. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1572 | std::string style_name = out_resource->name.entry; | 
|  | 1573 | size_t pos = style_name.find_last_of(u'.'); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1574 | if (pos != std::string::npos) { | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1575 | style->parent_inferred = true; | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1576 | style->parent = Reference(ResourceName( | 
|  | 1577 | {}, ResourceNamedTypeWithDefaultName(ResourceType::kStyle), style_name.substr(0, pos))); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1578 | } | 
|  | 1579 | } | 
|  | 1580 |  | 
|  | 1581 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1582 | const size_t depth = parser->depth(); | 
|  | 1583 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1584 | if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1585 | // Skip text and comments. | 
|  | 1586 | continue; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1587 | } | 
|  | 1588 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1589 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1590 | const std::string& element_name = parser->element_name(); | 
|  | 1591 | if (element_namespace == "" && element_name == "item") { | 
|  | 1592 | error |= !ParseStyleItem(parser, style.get()); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1593 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1594 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1595 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1596 | << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1597 | error = true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1598 | } | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1599 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1600 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1601 | if (error) { | 
|  | 1602 | return false; | 
|  | 1603 | } | 
|  | 1604 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1605 | out_resource->value = std::move(style); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1606 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1607 | } | 
|  | 1608 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 1609 | bool ResourceParser::ParseArray(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 1610 | uint32_t resource_format = android::ResTable_map::TYPE_ANY; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1611 | if (std::optional<StringPiece> format_attr = xml::FindNonEmptyAttribute(parser, "format")) { | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 1612 | resource_format = ParseFormatTypeNoEnumsOrFlags(format_attr.value()); | 
|  | 1613 | if (resource_format == 0u) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1614 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 1615 | << "'" << format_attr.value() << "' is an invalid format"); | 
|  | 1616 | return false; | 
|  | 1617 | } | 
|  | 1618 | } | 
|  | 1619 | return ParseArrayImpl(parser, out_resource, resource_format); | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1620 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1621 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 1622 | bool ResourceParser::ParseIntegerArray(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 1623 | return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_INTEGER); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1624 | } | 
|  | 1625 |  | 
| Adam Lesinski | d5fd76a | 2017-05-16 12:18:08 -0700 | [diff] [blame] | 1626 | bool ResourceParser::ParseStringArray(xml::XmlPullParser* parser, ParsedResource* out_resource) { | 
|  | 1627 | return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_STRING); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1628 | } | 
|  | 1629 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1630 | bool ResourceParser::ParseArrayImpl(xml::XmlPullParser* parser, | 
|  | 1631 | ParsedResource* out_resource, | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1632 | const uint32_t typeMask) { | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1633 | out_resource->name.type = | 
|  | 1634 | ResourceNamedTypeWithDefaultName(ResourceType::kArray).ToResourceNamedType(); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1635 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1636 | std::unique_ptr<Array> array = util::make_unique<Array>(); | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1637 |  | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 1638 | bool translatable = options_.translatable; | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1639 | if (std::optional<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) { | 
|  | 1640 | std::optional<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value()); | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 1641 | if (!maybe_translatable) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1642 | diag_->Error(android::DiagMessage(out_resource->source) | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1643 | << "invalid value for 'translatable'. Must be a boolean"); | 
|  | 1644 | return false; | 
| Adam Lesinski | 458b877 | 2016-04-25 14:20:21 -0700 | [diff] [blame] | 1645 | } | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 1646 | translatable = maybe_translatable.value(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1647 | } | 
| Adam Lesinski | 7542162 | 2017-01-06 15:20:04 -0800 | [diff] [blame] | 1648 | array->SetTranslatable(translatable); | 
| Adam Lesinski | 458b877 | 2016-04-25 14:20:21 -0700 | [diff] [blame] | 1649 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1650 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1651 | const size_t depth = parser->depth(); | 
|  | 1652 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1653 | if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1654 | // Skip text and comments. | 
|  | 1655 | continue; | 
| Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1656 | } | 
|  | 1657 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1658 | const android::Source item_source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1659 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1660 | const std::string& element_name = parser->element_name(); | 
|  | 1661 | if (element_namespace.empty() && element_name == "item") { | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 1662 | auto flag = GetFlag(parser); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1663 | std::unique_ptr<Item> item = ParseXml(parser, typeMask, kNoRawString); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1664 | if (!item) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1665 | diag_->Error(android::DiagMessage(item_source) << "could not parse array item"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1666 | error = true; | 
|  | 1667 | continue; | 
|  | 1668 | } | 
| Jeremy Meyer | 3d8d4a1 | 2024-08-23 17:29:03 -0700 | [diff] [blame^] | 1669 | item->SetFlag(flag); | 
|  | 1670 | std::string err; | 
|  | 1671 | auto status = GetFlagStatus(flag, options_.feature_flag_values, &err); | 
|  | 1672 | if (status) { | 
|  | 1673 | item->SetFlagStatus(status.value()); | 
|  | 1674 | } else { | 
|  | 1675 | diag_->Error(android::DiagMessage(item_source) << err); | 
|  | 1676 | error = true; | 
|  | 1677 | continue; | 
|  | 1678 | } | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1679 | item->SetSource(item_source); | 
| Adam Lesinski | 4ffea04 | 2017-08-10 15:37:28 -0700 | [diff] [blame] | 1680 | array->elements.emplace_back(std::move(item)); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1681 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1682 | diag_->Error(android::DiagMessage(source_.WithLine(parser->line_number())) | 
|  | 1683 | << "unknown tag <" << element_namespace << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1684 | error = true; | 
|  | 1685 | } | 
|  | 1686 | } | 
|  | 1687 |  | 
|  | 1688 | if (error) { | 
|  | 1689 | return false; | 
|  | 1690 | } | 
|  | 1691 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1692 | out_resource->value = std::move(array); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1693 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1694 | } | 
|  | 1695 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1696 | bool ResourceParser::ParsePlural(xml::XmlPullParser* parser, | 
|  | 1697 | ParsedResource* out_resource) { | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1698 | out_resource->name.type = | 
|  | 1699 | ResourceNamedTypeWithDefaultName(ResourceType::kPlurals).ToResourceNamedType(); | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1700 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1701 | std::unique_ptr<Plural> plural = util::make_unique<Plural>(); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1702 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1703 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1704 | const size_t depth = parser->depth(); | 
|  | 1705 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1706 | if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1707 | // Skip text and comments. | 
|  | 1708 | continue; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1709 | } | 
|  | 1710 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1711 | const android::Source item_source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1712 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1713 | const std::string& element_name = parser->element_name(); | 
|  | 1714 | if (element_namespace.empty() && element_name == "item") { | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1715 | std::optional<StringPiece> maybe_quantity = xml::FindNonEmptyAttribute(parser, "quantity"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1716 | if (!maybe_quantity) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1717 | diag_->Error(android::DiagMessage(item_source) << "<item> in <plurals> requires attribute " | 
|  | 1718 | << "'quantity'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1719 | error = true; | 
|  | 1720 | continue; | 
|  | 1721 | } | 
| Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 1722 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1723 | StringPiece trimmed_quantity = | 
|  | 1724 | util::TrimWhitespace(maybe_quantity.value()); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1725 | size_t index = 0; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1726 | if (trimmed_quantity == "zero") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1727 | index = Plural::Zero; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1728 | } else if (trimmed_quantity == "one") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1729 | index = Plural::One; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1730 | } else if (trimmed_quantity == "two") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1731 | index = Plural::Two; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1732 | } else if (trimmed_quantity == "few") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1733 | index = Plural::Few; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1734 | } else if (trimmed_quantity == "many") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1735 | index = Plural::Many; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1736 | } else if (trimmed_quantity == "other") { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1737 | index = Plural::Other; | 
|  | 1738 | } else { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1739 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1740 | << "<item> in <plural> has invalid value '" << trimmed_quantity | 
|  | 1741 | << "' for attribute 'quantity'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1742 | error = true; | 
|  | 1743 | continue; | 
|  | 1744 | } | 
|  | 1745 |  | 
|  | 1746 | if (plural->values[index]) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1747 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1748 | << "duplicate quantity '" << trimmed_quantity << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1749 | error = true; | 
|  | 1750 | continue; | 
|  | 1751 | } | 
|  | 1752 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1753 | if (!(plural->values[index] = ParseXml( | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1754 | parser, android::ResTable_map::TYPE_STRING, kNoRawString))) { | 
|  | 1755 | error = true; | 
| Ryan Mitchell | 2f9077d | 2019-02-15 16:02:09 -0800 | [diff] [blame] | 1756 | continue; | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1757 | } | 
| Ryan Mitchell | 2f9077d | 2019-02-15 16:02:09 -0800 | [diff] [blame] | 1758 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1759 | plural->values[index]->SetSource(item_source); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1760 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1761 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1762 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1763 | << "unknown tag <" << element_namespace << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1764 | error = true; | 
|  | 1765 | } | 
|  | 1766 | } | 
|  | 1767 |  | 
|  | 1768 | if (error) { | 
|  | 1769 | return false; | 
|  | 1770 | } | 
|  | 1771 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1772 | out_resource->value = std::move(plural); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1773 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1774 | } | 
|  | 1775 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1776 | bool ResourceParser::ParseDeclareStyleable(xml::XmlPullParser* parser, | 
|  | 1777 | ParsedResource* out_resource) { | 
| Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 1778 | out_resource->name.type = | 
|  | 1779 | ResourceNamedTypeWithDefaultName(ResourceType::kStyleable).ToResourceNamedType(); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1780 |  | 
| Donald Chai | 94e4a01 | 2020-01-06 13:52:41 -0800 | [diff] [blame] | 1781 | if (!options_.preserve_visibility_of_styleables) { | 
|  | 1782 | // This was added in change Idd21b5de4d20be06c6f8c8eb5a22ccd68afc4927 to mimic aapt1, but no one | 
|  | 1783 | // knows exactly what for. | 
|  | 1784 | // | 
|  | 1785 | // FWIW, styleables only appear in generated R classes.  For custom views these should always be | 
|  | 1786 | // package-private (to be used only by the view class); themes are a different story. | 
|  | 1787 | out_resource->visibility_level = Visibility::Level::kPublic; | 
|  | 1788 | } | 
| Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 1789 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1790 | // Declare-styleable only ends up in default config; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1791 | if (out_resource->config != ConfigDescription::DefaultConfig()) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1792 | diag_->Warn(android::DiagMessage(out_resource->source) | 
|  | 1793 | << "ignoring configuration '" << out_resource->config << "' for styleable " | 
|  | 1794 | << out_resource->name.entry); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1795 | out_resource->config = ConfigDescription::DefaultConfig(); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1796 | } | 
|  | 1797 |  | 
|  | 1798 | std::unique_ptr<Styleable> styleable = util::make_unique<Styleable>(); | 
|  | 1799 |  | 
|  | 1800 | std::string comment; | 
|  | 1801 | bool error = false; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1802 | const size_t depth = parser->depth(); | 
|  | 1803 | while (xml::XmlPullParser::NextChildNode(parser, depth)) { | 
|  | 1804 | if (parser->event() == xml::XmlPullParser::Event::kComment) { | 
| Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1805 | comment = std::string(util::TrimWhitespace(parser->comment())); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1806 | continue; | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1807 | } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1808 | // Ignore text. | 
|  | 1809 | continue; | 
| Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 1810 | } | 
|  | 1811 |  | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1812 | const android::Source item_source = source_.WithLine(parser->line_number()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1813 | const std::string& element_namespace = parser->element_namespace(); | 
|  | 1814 | const std::string& element_name = parser->element_name(); | 
|  | 1815 | if (element_namespace.empty() && element_name == "attr") { | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1816 | std::optional<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name"); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1817 | if (!maybe_name) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1818 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1819 | << "<attr> tag must have a 'name' attribute"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1820 | error = true; | 
|  | 1821 | continue; | 
|  | 1822 | } | 
| Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 1823 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1824 | // If this is a declaration, the package name may be in the name. Separate | 
|  | 1825 | // these out. | 
|  | 1826 | // Eg. <attr name="android:text" /> | 
| Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1827 | std::optional<Reference> maybe_ref = ResourceUtils::ParseXmlAttributeName(maybe_name.value()); | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1828 | if (!maybe_ref) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1829 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1830 | << "<attr> tag has invalid name '" << maybe_name.value() << "'"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1831 | error = true; | 
|  | 1832 | continue; | 
|  | 1833 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1834 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1835 | Reference& child_ref = maybe_ref.value(); | 
| Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1836 | xml::ResolvePackage(parser, &child_ref); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1837 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1838 | // Create the ParsedResource that will add the attribute to the table. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1839 | ParsedResource child_resource; | 
|  | 1840 | child_resource.name = child_ref.name.value(); | 
|  | 1841 | child_resource.source = item_source; | 
|  | 1842 | child_resource.comment = std::move(comment); | 
| Felka Chang | 5cf069b | 2021-10-27 00:06:04 +0800 | [diff] [blame] | 1843 | comment.clear(); | 
| Izabela Orlowska | c7ac3a1 | 2018-03-27 14:46:52 +0100 | [diff] [blame] | 1844 | if (options_.visibility) { | 
|  | 1845 | child_resource.visibility_level = options_.visibility.value(); | 
|  | 1846 | } | 
| Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 1847 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1848 | if (!ParseAttrImpl(parser, &child_resource, true)) { | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1849 | error = true; | 
|  | 1850 | continue; | 
|  | 1851 | } | 
| Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 1852 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1853 | // Create the reference to this attribute. | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1854 | child_ref.SetComment(child_resource.comment); | 
|  | 1855 | child_ref.SetSource(item_source); | 
|  | 1856 | styleable->entries.push_back(std::move(child_ref)); | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1857 |  | 
| Ryan Mitchell | acde95c3 | 2019-04-23 05:44:21 -0700 | [diff] [blame] | 1858 | // Do not add referenced attributes that do not define a format to the table. | 
|  | 1859 | CHECK(child_resource.value != nullptr); | 
|  | 1860 | Attribute* attr = ValueCast<Attribute>(child_resource.value.get()); | 
|  | 1861 |  | 
|  | 1862 | CHECK(attr != nullptr); | 
|  | 1863 | if (attr->type_mask != android::ResTable_map::TYPE_ANY) { | 
|  | 1864 | out_resource->child_resources.push_back(std::move(child_resource)); | 
|  | 1865 | } | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1866 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1867 | } else if (!ShouldIgnoreElement(element_namespace, element_name)) { | 
| Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1868 | diag_->Error(android::DiagMessage(item_source) | 
|  | 1869 | << "unknown tag <" << element_namespace << ":" << element_name << ">"); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1870 | error = true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1871 | } | 
|  | 1872 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1873 | comment = {}; | 
|  | 1874 | } | 
| Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 1875 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1876 | if (error) { | 
|  | 1877 | return false; | 
|  | 1878 | } | 
|  | 1879 |  | 
| Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1880 | out_resource->value = std::move(styleable); | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1881 | return true; | 
| Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1882 | } | 
|  | 1883 |  | 
| Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1884 | }  // namespace aapt |