commit fe05b7c7ca0739a8abeb05843aa113e31c2af357
author Nathaniel Nifong <nifong@google.com> Tue Sep 17 12:52:52 2019 -0400
committer Nathaniel Nifong <nifong@google.com> Thu Sep 19 11:34:48 2019 -0400
tree 4dd46492ec881d277f3abc11666e18ba0a2bc44e
parent 890ccb94ca4287e6da240e5c22d5c3ac05153e38

Check for null surface pointer in renderOverdraw

Bug: 141160420
Test: built
Change-Id: I5d6d4fc11f95f27ab6aa31377d3b94e71f14dca4

libs/hwui/pipeline/skia/SkiaPipeline.cpp

diff --git a/libs/hwui/pipeline/skia/SkiaPipeline.cpp b/libs/hwui/pipeline/skia/SkiaPipeline.cpp
index 67c181b..3010206 100644
--- a/libs/hwui/pipeline/skia/SkiaPipeline.cpp
+++ b/libs/hwui/pipeline/skia/SkiaPipeline.cpp
@@ -569,6 +569,7 @@
     // Set up the overdraw canvas.
     SkImageInfo offscreenInfo = SkImageInfo::MakeA8(surface->width(), surface->height());
     sk_sp<SkSurface> offscreen = surface->makeSurface(offscreenInfo);
+    LOG_ALWAYS_FATAL_IF(!offscreen, "Failed to create offscreen SkSurface for overdraw viz.");
     SkOverdrawCanvas overdrawCanvas(offscreen->getCanvas());
 
     // Fake a redraw to replay the draw commands.  This will increment the alpha channel