Fix retry logic for vibrator HAL requests
Update VibratorController to only retry loading the vibrator HAL info
when a transaction failure happens.
Bug: 325204954
Test: atest libvibratorservice_test
Change-Id: I37140420e3a07a1c217feb818de0717d407ad91b
diff --git a/services/core/jni/com_android_server_vibrator_VibratorController.cpp b/services/core/jni/com_android_server_vibrator_VibratorController.cpp
index f5e6c45..f47a59d 100644
--- a/services/core/jni/com_android_server_vibrator_VibratorController.cpp
+++ b/services/core/jni/com_android_server_vibrator_VibratorController.cpp
@@ -370,6 +370,7 @@
return JNI_FALSE;
}
vibrator::Info info = wrapper->getVibratorInfo();
+ info.logFailures();
if (info.capabilities.isOk()) {
env->CallObjectMethod(vibratorInfoBuilder, sVibratorInfoBuilderClassInfo.setCapabilities,
@@ -443,7 +444,7 @@
env->CallObjectMethod(vibratorInfoBuilder, sVibratorInfoBuilderClassInfo.setFrequencyProfile,
frequencyProfile);
- return info.isFailedLogged("vibratorGetInfo") ? JNI_FALSE : JNI_TRUE;
+ return info.shouldRetry() ? JNI_FALSE : JNI_TRUE;
}
static const JNINativeMethod method_table[] = {