commit f5c06a171c6eb51c6c914540b36a8211036fe735
author Prabir Pradhan <prabirmsp@google.com> Mon Apr 24 16:12:38 2023 +0000
committer Prabir Pradhan <prabirmsp@google.com> Tue May 02 16:02:36 2023 +0000
tree 86b19fa10e8692c6810499a63e757b34b1c2f70e
parent d160effd39d04a4638ffd23a9681a407efc78891

Clean up KeyEvent JNI APIs

Directly return a KeyEvent from KeyEvent_toNative, and change the
KeyEvent parameter from a pointer to a reference in KeyEvent_fromNative.

Bug: 279927189
Bug: 245989146
Test: Presubmit
Change-Id: I9c98700ea4645c6c4cb975fabfa25d1ff959bfc3

native/android/input.cpp

diff --git a/native/android/input.cpp b/native/android/input.cpp
index 1bff97d..64e8efe 100644
--- a/native/android/input.cpp
+++ b/native/android/input.cpp
@@ -87,11 +87,8 @@
 
 const AInputEvent* AKeyEvent_fromJava(JNIEnv* env, jobject keyEvent) {
     std::unique_ptr<KeyEvent> event = std::make_unique<KeyEvent>();
-    android::status_t ret = android::android_view_KeyEvent_toNative(env, keyEvent, event.get());
-    if (ret == android::OK) {
-        return event.release();
-    }
-    return nullptr;
+    *event = android::android_view_KeyEvent_toNative(env, keyEvent);
+    return event.release();
 }
 
 int64_t AKeyEvent_getEventTime(const AInputEvent* key_event) {