Idmap format changes for bidirectional lookup
This change modifies the idmap file format to allow for target resources
to map to arbitrary type/value combinations and to allow overlay
resources to be mapped back to target resource ids so references to
overlay resources can appear as references to target resources at
runtime.
The mappings of target resources to overlay resources and vice-versa are
both encoded as sparse arrays. Instead of looking up a resource by
indexing into an array that maps to the overlay resource id, the runtime
will binary search over the sparse array to find the type and value that
overlays the target resource.
Bug: 135943783
Test: idmap2_tests
Change-Id: I5d5344cdb7fe35f4f2e8d6781016299dea5d1e20
diff --git a/cmds/idmap2/libidmap2/RawPrintVisitor.cpp b/cmds/idmap2/libidmap2/RawPrintVisitor.cpp
index dd14fd4..13973d6 100644
--- a/cmds/idmap2/libidmap2/RawPrintVisitor.cpp
+++ b/cmds/idmap2/libidmap2/RawPrintVisitor.cpp
@@ -47,46 +47,94 @@
if (target_apk_) {
target_am_.SetApkAssets({target_apk_.get()});
}
+
+ overlay_apk_ = ApkAssets::Load(header.GetOverlayPath().to_string());
+ if (overlay_apk_) {
+ overlay_am_.SetApkAssets({overlay_apk_.get()});
+ }
}
void RawPrintVisitor::visit(const IdmapData& data ATTRIBUTE_UNUSED) {
+ const bool target_package_loaded = !target_am_.GetApkAssets().empty();
+ const bool overlay_package_loaded = !overlay_am_.GetApkAssets().empty();
+
+ for (auto& target_entry : data.GetTargetEntries()) {
+ Result<std::string> target_name(Error(""));
+ if (target_package_loaded) {
+ target_name = utils::ResToTypeEntryName(target_am_, target_entry.target_id);
+ }
+ if (target_name) {
+ print(target_entry.target_id, "target id: %s", target_name->c_str());
+ } else {
+ print(target_entry.target_id, "target id");
+ }
+
+ print(target_entry.data_type, "type: %s",
+ utils::DataTypeToString(target_entry.data_type).data());
+
+ Result<std::string> overlay_name(Error(""));
+ if (overlay_package_loaded && (target_entry.data_type == Res_value::TYPE_REFERENCE ||
+ target_entry.data_type == Res_value::TYPE_DYNAMIC_REFERENCE)) {
+ overlay_name = utils::ResToTypeEntryName(overlay_am_, target_entry.data_value);
+ }
+ if (overlay_name) {
+ print(target_entry.data_value, "value: %s", overlay_name->c_str());
+ } else {
+ print(target_entry.data_value, "value");
+ }
+ }
+
+ for (auto& overlay_entry : data.GetOverlayEntries()) {
+ Result<std::string> overlay_name(Error(""));
+ if (overlay_package_loaded) {
+ overlay_name = utils::ResToTypeEntryName(overlay_am_, overlay_entry.overlay_id);
+ }
+
+ if (overlay_name) {
+ print(overlay_entry.overlay_id, "overlay id: %s", overlay_name->c_str());
+ } else {
+ print(overlay_entry.overlay_id, "overlay id");
+ }
+
+ Result<std::string> target_name(Error(""));
+ if (target_package_loaded) {
+ target_name = utils::ResToTypeEntryName(target_am_, overlay_entry.target_id);
+ }
+
+ if (target_name) {
+ print(overlay_entry.target_id, "target id: %s", target_name->c_str());
+ } else {
+ print(overlay_entry.target_id, "target id");
+ }
+ }
+
+ const size_t string_pool_length = data.GetHeader()->GetStringPoolLength();
+ if (string_pool_length > 0) {
+ print_raw(string_pool_length, "%zu raw string pool bytes", string_pool_length);
+ }
}
void RawPrintVisitor::visit(const IdmapData::Header& header) {
- print(static_cast<uint16_t>(header.GetTargetPackageId()), "target package id");
- print(header.GetTypeCount(), "type count");
- last_seen_package_id_ = header.GetTargetPackageId();
+ print(header.GetTargetPackageId(), "target package id");
+ print(header.GetOverlayPackageId(), "overlay package id");
+ print(header.GetTargetEntryCount(), "target entry count");
+ print(header.GetOverlayEntryCount(), "overlay entry count");
+ print(header.GetStringPoolIndexOffset(), "string pool index offset");
+ print(header.GetStringPoolLength(), "string pool byte length");
}
-void RawPrintVisitor::visit(const IdmapData::TypeEntry& type_entry) {
- const bool target_package_loaded = !target_am_.GetApkAssets().empty();
+// NOLINTNEXTLINE(cert-dcl50-cpp)
+void RawPrintVisitor::print(uint8_t value, const char* fmt, ...) {
+ va_list ap;
+ va_start(ap, fmt);
+ std::string comment;
+ base::StringAppendV(&comment, fmt, ap);
+ va_end(ap);
- print(static_cast<uint16_t>(type_entry.GetTargetTypeId()), "target type");
- print(static_cast<uint16_t>(type_entry.GetOverlayTypeId()), "overlay type");
- print(static_cast<uint16_t>(type_entry.GetEntryCount()), "entry count");
- print(static_cast<uint16_t>(type_entry.GetEntryOffset()), "entry offset");
+ stream_ << base::StringPrintf("%08zx: %02x", offset_, value) << " " << comment
+ << std::endl;
- for (uint16_t i = 0; i < type_entry.GetEntryCount(); i++) {
- const EntryId entry = type_entry.GetEntry(i);
- if (entry == kNoEntry) {
- print(kPadding, "no entry");
- } else {
- const ResourceId target_resid = RESID(last_seen_package_id_, type_entry.GetTargetTypeId(),
- type_entry.GetEntryOffset() + i);
- const ResourceId overlay_resid =
- RESID(last_seen_package_id_, type_entry.GetOverlayTypeId(), entry);
- Result<std::string> name(Error(""));
- if (target_package_loaded) {
- name = utils::ResToTypeEntryName(target_am_, target_resid);
- }
- if (name) {
- print(static_cast<uint32_t>(entry), "0x%08x -> 0x%08x %s", target_resid, overlay_resid,
- name->c_str());
- } else {
- print(static_cast<uint32_t>(entry), "0x%08x -> 0x%08x", target_resid, overlay_resid);
- }
- }
- }
+ offset_ += sizeof(uint8_t);
}
// NOLINTNEXTLINE(cert-dcl50-cpp)
@@ -123,10 +171,23 @@
base::StringAppendV(&comment, fmt, ap);
va_end(ap);
- stream_ << base::StringPrintf("%08zx: ", offset_) << "........ " << comment << ": " << value
+ stream_ << base::StringPrintf("%08zx: ", offset_) << "........ " << comment << ": " << value
<< std::endl;
offset_ += kIdmapStringLength;
}
+// NOLINTNEXTLINE(cert-dcl50-cpp)
+void RawPrintVisitor::print_raw(uint32_t length, const char* fmt, ...) {
+ va_list ap;
+ va_start(ap, fmt);
+ std::string comment;
+ base::StringAppendV(&comment, fmt, ap);
+ va_end(ap);
+
+ stream_ << base::StringPrintf("%08zx: ", offset_) << "........ " << comment << std::endl;
+
+ offset_ += length;
+}
+
} // namespace android::idmap2