Improve error message when invalid display id is passed to screencap with -d argument.
Change-Id: Ifd38b347b64d1f6fc28f99c47adcab974e8e2467
Test: adb shell screencap -d 0 -p /tmp/test.png
Bug: 306733214
Fix: 306733214
Flag: EXEMPT bugfix
diff --git a/cmds/screencap/Android.bp b/cmds/screencap/Android.bp
index 16026ec..9f350b1 100644
--- a/cmds/screencap/Android.bp
+++ b/cmds/screencap/Android.bp
@@ -7,25 +7,66 @@
default_applicable_licenses: ["frameworks_base_license"],
}
-cc_binary {
- name: "screencap",
-
- srcs: ["screencap.cpp"],
-
- shared_libs: [
- "libcutils",
- "libutils",
- "libbinder",
- "libjnigraphics",
- "libhwui",
- "libui",
- "libgui",
- ],
+cc_defaults {
+ name: "screencap_defaults",
cflags: [
"-Wall",
"-Werror",
- "-Wunused",
"-Wunreachable-code",
+ "-Wunused",
+ ],
+
+ shared_libs: [
+ "libbinder",
+ "libcutils",
+ "libgui",
+ "libhwui",
+ "libjnigraphics",
+ "libui",
+ "libutils",
+ ],
+}
+
+cc_library {
+ name: "libscreencap",
+
+ defaults: [
+ "screencap_defaults",
+ ],
+
+ srcs: ["screencap_utils.cpp"],
+}
+
+cc_binary {
+ name: "screencap",
+
+ defaults: [
+ "screencap_defaults",
+ ],
+
+ srcs: ["screencap.cpp"],
+
+ static_libs: [
+ "libscreencap",
+ ],
+}
+
+cc_test {
+ name: "libscreencap_test",
+
+ defaults: [
+ "screencap_defaults",
+ ],
+
+ test_suites: ["device-tests"],
+
+ srcs: [
+ "tests/screencap_test.cpp",
+ ],
+
+ static_libs: [
+ "libgmock",
+ "libscreencap",
],
}