commit d50cec8b1f8252cce490111b9bf8263068255acb
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> Fri Jun 21 00:48:11 2024 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Fri Jun 21 00:48:11 2024 +0000
tree 3dde5cab4178dea8449cb5fed1d9f503f103b3c5
parent c258f27b561c3890414819676adbff831813a9a0
parent 744f8ff8b26dbc859a638033a18f89d0f2ec3305

Merge "Revert "Adding in verification of calling UID in onShellCommand"" into rvc-dev am: 75aaa4c2ea am: e327817f65 am: c4cd5efae8 am: d03e368756 am: fb517df3a7 am: 768f53651e am: 744f8ff8b2

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/26191039

Change-Id: I9b4af1f2a83883f18a8776893ac0b0c26c4ef9ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

services/core/java/com/android/server/am/ActivityManagerService.java

diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java
index 70bef60..c1e576a 100644
--- a/services/core/java/com/android/server/am/ActivityManagerService.java
+++ b/services/core/java/com/android/server/am/ActivityManagerService.java
@@ -9275,13 +9275,6 @@
     public void onShellCommand(FileDescriptor in, FileDescriptor out,
             FileDescriptor err, String[] args, ShellCallback callback,
             ResultReceiver resultReceiver) {
-        final int callingUid = Binder.getCallingUid();
-        if (callingUid != ROOT_UID && callingUid != Process.SHELL_UID) {
-            if (resultReceiver != null) {
-                resultReceiver.send(-1, null);
-            }
-            throw new SecurityException("Shell commands are only callable by root or shell");
-        }
         (new ActivityManagerShellCommand(this, false)).exec(
                 this, in, out, err, args, callback, resultReceiver);
     }