commit ca0c18dc4cb68f55143cf97b053acae9ec8ecaed
author Philip P. Moltmann <moltmann@google.com> Mon Jul 06 14:45:14 2020 -0700
committer Philip P. Moltmann <moltmann@google.com> Mon Jul 06 14:48:17 2020 -0700
tree f1628cbba0b059108212fcc63c4e54f1f2c95909
parent fc66314259cf643728ec6c9e5c4a0d6431fd9507

Make pending intents of uninstall failure immutable

They just link to settings. There is no need to modify them. On the
other handle the package installer app has elevated powers, hence better
restrict what can be launched with its powers.

Test: Built
Bug: 156011946
Change-Id: Ie78ec626235a9fd344d01075d08a072fa7a44e12

packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java

diff --git a/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java b/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java
index 5a51ac2..973ab89 100644
--- a/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java
+++ b/packages/PackageInstaller/src/com/android/packageinstaller/UninstallFinish.java
@@ -239,8 +239,8 @@
         builder.addAction((new Notification.Action.Builder(
                 Icon.createWithResource(context, R.drawable.ic_settings_multiuser),
                 context.getString(R.string.manage_users),
-                PendingIntent.getActivity(context, 0, intent,
-                        PendingIntent.FLAG_UPDATE_CURRENT))).build());
+                PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT
+                        | PendingIntent.FLAG_IMMUTABLE))).build());
     }
 
     /**
@@ -259,7 +259,7 @@
         builder.addAction((new Notification.Action.Builder(
                 Icon.createWithResource(context, R.drawable.ic_lock),
                 context.getString(R.string.manage_device_administrators),
-                PendingIntent.getActivity(context, 0, intent,
-                        PendingIntent.FLAG_UPDATE_CURRENT))).build());
+                PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT
+                        | PendingIntent.FLAG_IMMUTABLE))).build());
     }
 }