app_main: silence static analyzer warnings
This silences two warnings:
frameworks/base/cmds/app_process/app_main.cpp:238:11: warning: Potential
memory leak
frameworks/base/cmds/app_process/app_main.cpp:261:9: warning: Potential
memory leak
As the (existing) comment notes, we nuke argv later in main(), so these
copies are necessary. Since these args need to live for basically the
entire life of the process, it seems pointless to go out of our way to
free them.
Bug: 27101951
Test: mma. Static analyzer warnings are gone.
Change-Id: Icbfabfede9db909f6acb274b697cb6076c3fc11f
diff --git a/cmds/app_process/app_main.cpp b/cmds/app_process/app_main.cpp
index 0ea141c..752c2a8 100644
--- a/cmds/app_process/app_main.cpp
+++ b/cmds/app_process/app_main.cpp
@@ -233,6 +233,9 @@
for (i = 0; i < argc; i++) {
if (known_command == true) {
runtime.addOption(strdup(argv[i]));
+ // The static analyzer gets upset that we don't ever free the above
+ // string. Since the allocation is from main, leaking it doesn't seem
+ // problematic. NOLINTNEXTLINE
ALOGV("app_process main add known option '%s'", argv[i]);
known_command = false;
continue;
@@ -256,6 +259,9 @@
}
runtime.addOption(strdup(argv[i]));
+ // The static analyzer gets upset that we don't ever free the above
+ // string. Since the allocation is from main, leaking it doesn't seem
+ // problematic. NOLINTNEXTLINE
ALOGV("app_process main add option '%s'", argv[i]);
}