commit bd4ab0384061ef64a64a1ed3e2dae8667c7743de
author wilsonshih <wilsonshih@google.com> Mon Oct 31 10:56:36 2022 +0800
committer Wei Sheng Shih <wilsonshih@google.com> Fri Jan 06 01:33:03 2023 +0000
tree 1ec3f7505ccab2f4f1198428e64c5ec26ba35bd8
parent 61d3c91e4f807392bafe72dcd68bae78e07fc77d

Fixes NPE crash when VRI#setView fail before input stage was create.

Also catch RuntimeException for addToDisplayAsUser in case the throwing
type was not RemoteException.

Bug: 253200800
Bug: 263078961
Test: Simulate to throw a runtime exception in WMS#addWindow, and verify
VRI#setView should catch that exception, and clear resources without
crash.

Change-Id: Ia113b836e4a18c656093f9db7f63e9c50c427e6c
Merged-In: Ia113b836e4a18c656093f9db7f63e9c50c427e6c
(cherry picked from commit f1a574074ac81906be3a2a500aae96f8da330733)

core/java/android/view/ViewRootImpl.java

diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java
index 6f4a63c..8d52d00 100644
--- a/core/java/android/view/ViewRootImpl.java
+++ b/core/java/android/view/ViewRootImpl.java
@@ -1274,7 +1274,7 @@
                     mTmpFrames.attachedFrame = attachedFrame;
                     mTmpFrames.compatScale = compatScale[0];
                     mInvCompatScale = 1f / compatScale[0];
-                } catch (RemoteException e) {
+                } catch (RemoteException | RuntimeException e) {
                     mAdded = false;
                     mView = null;
                     mAttachInfo.mRootView = null;