commit b48ae8a1adb4b301061ad083c7f0bd70e9336fe5
author Bart Van Assche <bvanassche@google.com> Fri Aug 02 10:12:22 2024 -0700
committer Bart Van Assche <bvanassche@google.com> Sat Aug 03 06:44:38 2024 -0700
tree e7cf6cd2349b8459d0df527665026a75e4584296
parent c33762ca7a6b766cce24808cae3a73be99bdf1b1

Clean up the JetPlayer class definition

Make the following changes:
- Declare constructors 'explicit' as recommended in go/totw/142.
- Remove a set-but-not-used variable because the compiler warns about it.
- Remove the default JetPlayer constructor because defining a default
  constructor contradicts the comment that says that there is no default
  constructor.

Change-Id: I3b6addedc78e1efbced3e43de5c75cafd9ad24fc
Signed-off-by: Bart Van Assche <bvanassche@google.com>

media/jni/JetPlayer.h

diff --git a/media/jni/JetPlayer.h b/media/jni/JetPlayer.h
index bb569bc..4cc266d 100644
--- a/media/jni/JetPlayer.h
+++ b/media/jni/JetPlayer.h
@@ -40,7 +40,7 @@
     static const int JET_NUMQUEUEDSEGMENT_UPDATE = 3;
     static const int JET_PAUSE_UPDATE            = 4;
 
-    JetPlayer(void *javaJetPlayer,
+    explicit JetPlayer(void *javaJetPlayer,
             int maxTracks = 32,
             int trackBufferSize = 1200);
     ~JetPlayer();
@@ -69,7 +69,6 @@
     void                fireUpdateOnStatusChange();
     void                fireEventsFromJetQueue();
 
-    JetPlayer() {} // no default constructor
     void dump();
     void dumpJetStatus(S_JET_STATUS* pJetStatus);
 
@@ -96,7 +95,7 @@
 
     class JetPlayerThread : public Thread {
     public:
-        JetPlayerThread(JetPlayer *player) : mPlayer(player) {
+        explicit JetPlayerThread(JetPlayer *player) : mPlayer(player) {
         }
 
     protected:
@@ -106,8 +105,7 @@
         JetPlayer *mPlayer;
 
         bool threadLoop() {
-            int result;
-            result = mPlayer->render();
+            mPlayer->render();
             return false;
         }