Execute transition by starting window only if visible requested
Otherwise the activity may not have been added as opening app for
transition, which causes the animation to be skipped. Such as if the
previous activity doesn't need to pause or take long time to pause,
then its visible-requested is still false.
Bug: 161781889
Test: Cold launch Settings to freeform:
adb shell am start -n "com.android.settings/.Settings " \
--windowingMode 5
There should be transition animation.
Change-Id: If339b1e9e5f004087dcbf2be3c8ab7a9f5524c5b
(cherry picked from commit 37d61f3b05ae58dd82b4f9a2eac9c979a814016a)
diff --git a/services/core/java/com/android/server/wm/ActivityRecord.java b/services/core/java/com/android/server/wm/ActivityRecord.java
index 995ddb2..f48c453 100644
--- a/services/core/java/com/android/server/wm/ActivityRecord.java
+++ b/services/core/java/com/android/server/wm/ActivityRecord.java
@@ -6337,7 +6337,7 @@
// starting window is drawn, the transition can start earlier. Exclude finishing and bubble
// because it may be a trampoline.
if (!wasTaskVisible && mStartingData != null && !finishing && !mLaunchedFromBubble
- && !mDisplayContent.mAppTransition.isReady()
+ && mVisibleRequested && !mDisplayContent.mAppTransition.isReady()
&& !mDisplayContent.mAppTransition.isRunning()
&& mDisplayContent.isNextTransitionForward()) {
// The pending transition state will be cleared after the transition is started, so