Respond to API Review comments on MediaDrm
1. Use getters instead of accessing LogMessage fields directly
2. LogMessage should be final
bug: 182945242
Change-Id: Ia8e9b7ae23fc2b5aa226d742621da8f022e5a583
diff --git a/core/api/current.txt b/core/api/current.txt
index b3ce06b..77005a4 100644
--- a/core/api/current.txt
+++ b/core/api/current.txt
@@ -22185,10 +22185,10 @@
field public static final int STATUS_USABLE_IN_FUTURE = 5; // 0x5
}
- public static class MediaDrm.LogMessage {
- field @NonNull public final String message;
- field public final int priority;
- field public final long timestampMillis;
+ public static final class MediaDrm.LogMessage {
+ method @NonNull public String getMessage();
+ method public int getPriority();
+ method public long getTimestampMillis();
}
public static final class MediaDrm.MediaDrmStateException extends java.lang.IllegalStateException {
diff --git a/media/java/android/media/MediaDrm.java b/media/java/android/media/MediaDrm.java
index 10b99dc..864350e 100644
--- a/media/java/android/media/MediaDrm.java
+++ b/media/java/android/media/MediaDrm.java
@@ -2991,13 +2991,16 @@
* A {@link LogMessage} records an event in the {@link MediaDrm} framework
* or vendor plugin.
*/
- public static class LogMessage {
+ public static final class LogMessage {
+ private final long timestampMillis;
+ private final int priority;
+ private final String message;
/**
* Timing of the recorded event measured in milliseconds since the Epoch,
* 1970-01-01 00:00:00 +0000 (UTC).
*/
- public final long timestampMillis;
+ public final long getTimestampMillis() { return timestampMillis; }
/**
* Priority of the recorded event.
@@ -3013,13 +3016,13 @@
* </ul>
*/
@Log.Level
- public final int priority;
+ public final int getPriority() { return priority; }
/**
* Description of the recorded event.
*/
@NonNull
- public final String message;
+ public final String getMessage() { return message; }
private LogMessage(long timestampMillis, int priority, String message) {
this.timestampMillis = timestampMillis;