commit 9cc3b8424d10079d81769962a1e50ff63a82a7b5
author Daniel Akinola <dakinola@google.com> Mon Feb 24 19:04:33 2025 +0000
committer Daniel Akinola <dakinola@google.com> Mon Feb 24 19:04:33 2025 +0000
tree 99c5f25a3167802850478bf1a25956f9ebb46375
parent e282072383a82df6a31d1bbed9a9b0aceca4817d

Update "Open in Browser" dialog to meet a11y guideline

* Updating OK button to be 48dp height
* Updating line height of description text so that when font size is
  max, words don't overlap

Fix: 397859648
Fix: 397866754
Test: Open Youtube in desktop windowing and click gear icon to launch
dialog
Flag: EXEMPT bugfix

Change-Id: I3e6beae488bc6856930c3a401e5e6798d11cc7fc

libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml

diff --git a/libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml b/libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml
index f6256e6..ed5b339 100644
--- a/libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml
+++ b/libs/WindowManager/Shell/res/layout/open_by_default_settings_dialog.xml
@@ -72,7 +72,7 @@
                     android:layout_height="wrap_content"
                     android:textSize="12sp"
                     android:textFontWeight="400"
-                    android:lineHeight="16dp"
+                    android:lineHeight="28dp"
                     android:layout_gravity="center_horizontal"
                     android:layout_marginBottom="16dp"
                     android:textColor="@androidprv:color/materialColorOnSurfaceVariant"
@@ -113,12 +113,13 @@
                 <Button
                     android:id="@+id/open_by_default_settings_dialog_confirm_button"
                     android:layout_width="wrap_content"
-                    android:layout_height="36dp"
+                    android:layout_height="wrap_content"
+                    android:minHeight="48dp"
                     android:text="@string/open_by_default_dialog_dismiss_button_text"
                     android:layout_gravity="end"
                     android:layout_marginHorizontal="24dp"
-                    android:layout_marginTop="32dp"
-                    android:layout_marginBottom="24dp"
+                    android:layout_marginTop="26dp"
+                    android:layout_marginBottom="18dp"
                     android:textSize="14sp"
                     android:textFontWeight="500"
                     android:textColor="@androidprv:color/materialColorOnPrimary"