commit 9989d67752ae992b6cebf6c5f019dcb8dddd0a55
author lijilou <lijilou@xiaomi.corp-partner.google.com> Wed Dec 25 17:17:38 2024 +0800
committer Jilou li <lijilou@xiaomi.corp-partner.google.com> Wed Dec 25 19:31:48 2024 -0800
tree eff7b3f4c2e00715c2c3a8796bea85f97bcfb0dc
parent 6407e3b6f6cdc205d20980e8ff32d84c550ceac6

remove the wms lock in notifyMovementBoundsChanged method.

ALL callers call the notifyMovementBoundsChanged  with the wms lock,we
don't need add lock in this method.

Bug: none
Flag: EXEMPT minor optimization
Change-Id: I20940378b1384f1b57cfb2b41bf1cf94beeb4da0

services/core/java/com/android/server/wm/PinnedTaskController.java

diff --git a/services/core/java/com/android/server/wm/PinnedTaskController.java b/services/core/java/com/android/server/wm/PinnedTaskController.java
index 755d4c8..6dd7d35 100644
--- a/services/core/java/com/android/server/wm/PinnedTaskController.java
+++ b/services/core/java/com/android/server/wm/PinnedTaskController.java
@@ -348,12 +348,14 @@
      * Notifies listeners that the PIP needs to be adjusted for the IME.
      */
     private void notifyImeVisibilityChanged(boolean imeVisible, int imeHeight) {
-        if (mPinnedTaskListener != null) {
-            try {
-                mPinnedTaskListener.onImeVisibilityChanged(imeVisible, imeHeight);
-            } catch (RemoteException e) {
-                Slog.e(TAG_WM, "Error delivering bounds changed event.", e);
-            }
+        if (mPinnedTaskListener == null) {
+            return;
+        }
+
+        try {
+            mPinnedTaskListener.onImeVisibilityChanged(imeVisible, imeHeight);
+        } catch (RemoteException e) {
+            Slog.e(TAG_WM, "Error delivering ime visibility changed event.", e);
         }
     }
 
@@ -361,15 +363,14 @@
      * Notifies listeners that the PIP movement bounds have changed.
      */
     private void notifyMovementBoundsChanged(boolean fromImeAdjustment) {
-        synchronized (mService.mGlobalLock) {
-            if (mPinnedTaskListener == null) {
-                return;
-            }
-            try {
-                mPinnedTaskListener.onMovementBoundsChanged(fromImeAdjustment);
-            } catch (RemoteException e) {
-                Slog.e(TAG_WM, "Error delivering actions changed event.", e);
-            }
+        if (mPinnedTaskListener == null) {
+            return;
+        }
+
+        try {
+            mPinnedTaskListener.onMovementBoundsChanged(fromImeAdjustment);
+        } catch (RemoteException e) {
+            Slog.e(TAG_WM, "Error delivering movement bounds changed event.", e);
         }
     }