commit 8c7e75ebc9c2db43bf6c1a492547e194eb633e5e
author Bart Van Assche <bvanassche@google.com> Tue Aug 06 13:52:47 2024 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Aug 06 13:52:47 2024 +0000
tree 208de88c9fe3f9abe3c076f60b0835ce7cf57281
parent 0ae8a2dd4de914190936d4c341783c820567a528
parent b48ae8a1adb4b301061ad083c7f0bd70e9336fe5

Merge "Clean up the JetPlayer class definition" into main

media/jni/JetPlayer.h

diff --git a/media/jni/JetPlayer.h b/media/jni/JetPlayer.h
index bb569bc..4cc266d 100644
--- a/media/jni/JetPlayer.h
+++ b/media/jni/JetPlayer.h
@@ -40,7 +40,7 @@
     static const int JET_NUMQUEUEDSEGMENT_UPDATE = 3;
     static const int JET_PAUSE_UPDATE            = 4;
 
-    JetPlayer(void *javaJetPlayer,
+    explicit JetPlayer(void *javaJetPlayer,
             int maxTracks = 32,
             int trackBufferSize = 1200);
     ~JetPlayer();
@@ -69,7 +69,6 @@
     void                fireUpdateOnStatusChange();
     void                fireEventsFromJetQueue();
 
-    JetPlayer() {} // no default constructor
     void dump();
     void dumpJetStatus(S_JET_STATUS* pJetStatus);
 
@@ -96,7 +95,7 @@
 
     class JetPlayerThread : public Thread {
     public:
-        JetPlayerThread(JetPlayer *player) : mPlayer(player) {
+        explicit JetPlayerThread(JetPlayer *player) : mPlayer(player) {
         }
 
     protected:
@@ -106,8 +105,7 @@
         JetPlayer *mPlayer;
 
         bool threadLoop() {
-            int result;
-            result = mPlayer->render();
+            mPlayer->render();
             return false;
         }