commit 8a1346ce7aa21c8294a0eb8214fdf55149afa246
author Guojing Yuan <guojing@google.com> Thu Mar 21 22:12:07 2024 +0000
committer Guojing Yuan <guojing@google.com> Tue Apr 02 17:35:25 2024 +0000
tree ac98de7e0a1e8f2dfdb7974640faf3374d8649f6
parent b614ab29133b68121a850a2a50c327b46503d35a

[DO NOT MERGE][CDM] Fix a security issue that allow 3p apps to skip prompt by setSkipPrompt

Fix: 329230490

Change-Id: I6e4dd33cbf98293d7efa0a40c0668d6c5242059a
Test: CTS

services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java

diff --git a/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java b/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
index ff8881b..6be6902 100644
--- a/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
+++ b/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
@@ -430,10 +430,8 @@
             mCallingPackage = callingPackage;
             request.setCallingPackage(callingPackage);
 
-            if (mayAssociateWithoutPrompt(callingPackage, userId)) {
-                Slog.i(LOG_TAG, "setSkipPrompt(true)");
-                request.setSkipPrompt(true);
-            }
+            request.setSkipPrompt(mayAssociateWithoutPrompt(callingPackage, userId));
+
             callback.asBinder().linkToDeath(CompanionDeviceManagerService.this /* recipient */, 0);
 
             AndroidFuture<String> fetchProfileDescription =