commit 76f0f19a329d8bf3a8fbd20374067af275202186
author TYM Tsai <tymtsai@google.com> Thu Feb 17 01:47:29 2022 +0800
committer TYM Tsai <tymtsai@google.com> Wed Feb 16 20:16:57 2022 +0000
tree 3c6a7b952cb8ad52cd717b3b814522365acb643a
parent 1a8f58e7e5a7278c6c13d2c36744914aedcff590

Show only dialog presentations in the fill dialog

Remove fallback to dropdown presentation if there is no dialog
presentation. So the fill dialog will only shows suggestions
that is exactly set a dialog presentation.

Bug: 219956625
Test: Manual
Change-Id: I5665e98b17dc2dcff252af3579a69e9a832f8385

services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java

diff --git a/services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java b/services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java
index e122993..75d9b7e 100644
--- a/services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java
+++ b/services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java
@@ -275,12 +275,10 @@
             if (index >= 0) {
                 RemoteViews presentation = dataset.getFieldDialogPresentation(index);
                 if (presentation == null) {
-                    Slog.w(TAG, "fallback to presentation");
-                    presentation = dataset.getFieldPresentation(index);
-                }
-                if (presentation == null) {
-                    Slog.w(TAG, "not displaying UI on field " + focusedViewId + " because "
-                            + "service didn't provide a presentation for it on " + dataset);
+                    if (sDebug) {
+                        Slog.w(TAG, "not displaying UI on field " + focusedViewId + " because "
+                                + "service didn't provide a presentation for it on " + dataset);
+                    }
                     continue;
                 }
                 final View view;