commit 765dea01d900817e88c7604b3c7d37bdee8015d2
author Felipe Leme <felipeal@google.com> Thu Nov 10 21:34:57 2022 +0000
committer Felipe Leme <felipeal@google.com> Thu Nov 10 22:16:44 2022 +0000
tree 272bfbd3af3f027ad306105e614ffe0a0e5af2f7
parent 11791dcdc9d10a34235f8621660c26259c82e378

Fixed initial user on UserVisibilityMediator.

Otherwise, the system user never finishes booting as when
WindowManager calls isUserVisible(0), it will return false.

Fixes: 258696493
Test: it boots!
Test: atest UserVisibilityMediatorSUSDTest atest UserVisibilityMediatorMUMDTest

Change-Id: I316e1469977e7a04389d7e0cfab0ff88d3b42481

services/core/java/com/android/server/pm/UserVisibilityMediator.java

diff --git a/services/core/java/com/android/server/pm/UserVisibilityMediator.java b/services/core/java/com/android/server/pm/UserVisibilityMediator.java
index 0015fad..bd81062 100644
--- a/services/core/java/com/android/server/pm/UserVisibilityMediator.java
+++ b/services/core/java/com/android/server/pm/UserVisibilityMediator.java
@@ -16,8 +16,8 @@
 package com.android.server.pm;
 
 import static android.content.pm.UserInfo.NO_PROFILE_GROUP_ID;
-import static android.os.UserHandle.USER_CURRENT;
 import static android.os.UserHandle.USER_NULL;
+import static android.os.UserHandle.USER_SYSTEM;
 import static android.view.Display.DEFAULT_DISPLAY;
 
 import android.annotation.IntDef;
@@ -54,10 +54,9 @@
 
     private static final String PREFIX_START_USER_RESULT = "START_USER_";
 
-    // NOTE: it's set as USER_CURRENT instead of USER_NULL because NO_PROFILE_GROUP_ID has the same
-    // falue of USER_NULL, which would complicate some checks (especially on unit tests)
+    // TODO(b/242195409): might need to change this if boot logic is refactored for HSUM devices
     @VisibleForTesting
-    static final int INITIAL_CURRENT_USER_ID = USER_CURRENT;
+    static final int INITIAL_CURRENT_USER_ID = USER_SYSTEM;
 
     public static final int START_USER_RESULT_SUCCESS_VISIBLE = 1;
     public static final int START_USER_RESULT_SUCCESS_INVISIBLE = 2;
@@ -126,7 +125,8 @@
                 }
                 if (foreground) {
                     Slogf.w(TAG, "startUser(%d, %d, %b, %d) failed: cannot start profile user in "
-                            + "foreground");
+                            + "foreground", userId, actualProfileGroupId, foreground,
+                            displayId);
                     return START_USER_RESULT_FAILURE;
                 } else {
                     boolean isParentRunning = mStartedProfileGroupIds