commit 68dbf2de90eef662feb0f3a5ad4319ae098cb6fd
author Kwangkyu Park <kk48.park@samsung.com> Wed Jul 31 21:54:29 2024 +0900
committer Kwangkyu Park <kk48.park@samsung.com> Fri Aug 02 05:11:51 2024 +0000
tree d9daf482337ac2b26b6836ead508ad9108b4da53
parent 37d1bca662a0813e02717a449d9cfe385d7af3fd

Camera: Fix camera id equal check

String type camera is being check with plain equality operator.
Change it to the proper equals() methods.

Bug: 356986790
Test: manual test by specifying logical id as physical id
Change-Id: I4fa82056a9219f7bcdc2e8856fe9742a65f41d75

core/java/android/hardware/camera2/impl/CameraDeviceImpl.java

diff --git a/core/java/android/hardware/camera2/impl/CameraDeviceImpl.java b/core/java/android/hardware/camera2/impl/CameraDeviceImpl.java
index 97c03ed..b909ab8 100644
--- a/core/java/android/hardware/camera2/impl/CameraDeviceImpl.java
+++ b/core/java/android/hardware/camera2/impl/CameraDeviceImpl.java
@@ -849,7 +849,7 @@
             checkIfCameraClosedOrInError();
 
             for (String physicalId : physicalCameraIdSet) {
-                if (physicalId == getId()) {
+                if (Objects.equals(physicalId, getId())) {
                     throw new IllegalStateException("Physical id matches the logical id!");
                 }
             }