commit 62d72f2e75b733675e9c68b9e734c53522740706
author Lyn Han <lynhan@google.com> Mon Nov 23 22:19:17 2020 -0600
committer Lyn Han <lynhan@google.com> Mon Nov 23 22:42:54 2020 -0600
tree ff46cc4fd471ea4b7c346d06bfcfa5a6d514b7a3
parent 44e16cd59f2e5128e14df1f7c82475b236e63a39

Fix race condition that skips corner updates on half swipe

Set mIsSwiping true before calling SwipeHelper#Callback#onBeginDrag;
otherwise onBeginDrag may use an outdated false and mistakenly include
the swiped view as part of a rounded section.

Fixes: 173753021
Bug: 171817112
Test: half swipe first and last notifs in section; corners always update
Change-Id: I115d30b10657b6edbf94d4d444058bdeeaf9000e

packages/SystemUI/src/com/android/systemui/SwipeHelper.java

diff --git a/packages/SystemUI/src/com/android/systemui/SwipeHelper.java b/packages/SystemUI/src/com/android/systemui/SwipeHelper.java
index 6151ac7..3852b24 100644
--- a/packages/SystemUI/src/com/android/systemui/SwipeHelper.java
+++ b/packages/SystemUI/src/com/android/systemui/SwipeHelper.java
@@ -327,8 +327,8 @@
                     if (Math.abs(delta) > pagingTouchSlop
                             && Math.abs(delta) > Math.abs(deltaPerpendicular)) {
                         if (mCallback.canChildBeDragged(mTouchedView)) {
-                            mCallback.onBeginDrag(mTouchedView);
                             mIsSwiping = true;
+                            mCallback.onBeginDrag(mTouchedView);
                             mInitialTouchPos = getPos(ev);
                             mTranslation = getTranslation(mTouchedView);
                         }