commit 44af3b320243f5b5f3c26a93f93d0d3924517d42
author Rafal Slawik <rslawik@google.com> Tue Apr 16 13:16:15 2019 +0100
committer Rafal Slawik <rslawik@google.com> Fri Apr 19 06:13:27 2019 +0000
tree 39ba7356bee58afbd6306fc3345b46d44d8c87bf
parent 84f4980bc26e774622b24730c5f4b1ecd9a1701d

Monitor swap

Pull value of VmSwap from /proc/PID/status when capturing
ProcessMemoryState atom.

Before change:
(average pull time nanos) 43355896
(max pull time nanos) 75649278

After change:
(average pull time nanos) 86307073
(max pull time nanos) 151681474

Delta: 2x increase
Pulling frequency is controled via statsd and we trade-off more
expensive reads for more actionable data (helping detect memory leaks).

Bug: 130624561
Test: atest MemoryStatUtilTest
Test: benchmark pulling ProcessMemoryState atom
Test: manually take a statsd report
Change-Id: I1d90563b70b5253b3d31ddab4810db870620c4d4
(cherry picked from commit 65a9b7122ada9db7a95cdfe31fa97b328bd04a06)

cmds/statsd/src/external/StatsPullerManager.cpp

diff --git a/cmds/statsd/src/external/StatsPullerManager.cpp b/cmds/statsd/src/external/StatsPullerManager.cpp
index ca73059..2ffe18e 100644
--- a/cmds/statsd/src/external/StatsPullerManager.cpp
+++ b/cmds/statsd/src/external/StatsPullerManager.cpp
@@ -146,7 +146,7 @@
           .puller = new StatsCompanionServicePuller(android::util::PROCESS_MEMORY_STATE)}},
         // native_process_memory_state
         {android::util::NATIVE_PROCESS_MEMORY_STATE,
-         {.additiveFields = {3, 4, 5, 6},
+         {.additiveFields = {3, 4, 5, 6, 8},
           .puller = new StatsCompanionServicePuller(android::util::NATIVE_PROCESS_MEMORY_STATE)}},
         // process_memory_high_water_mark
         {android::util::PROCESS_MEMORY_HIGH_WATER_MARK,