| commit | 424df66031d9e2bb6a41388e9ca447327bbf3c19 | [log] [tgz] |
|---|---|---|
| author | Ibrahim Yilmaz <iyz@google.com> | Tue Jul 09 13:41:12 2024 +0000 |
| committer | Ibrahim Yilmaz <iyz@google.com> | Tue Jul 09 13:43:47 2024 +0000 |
| tree | d67c093728a42079d96b4cb7bd7f1e1d58f2c6ea | |
| parent | d53bee22fa451a4a5aed20352d9c651a77eae9ab [diff] |
[Inline Reply] Not mark hasUserExpanded true for pinned notifs We dont need to mark notification hasUserExpanded true. It is done when pinning is set false. Bug: 346976443 Test: ExpandableNotificationRowTest Flag: com.android.systemui.expand_heads_up_on_inline_reply Change-Id: I84ea203d9a121b5392b99bfc35ed2e2ed1edfa75
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java index 9e943ee..582d847 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java
@@ -371,12 +371,6 @@ setUserExpanded(nowExpanded); } - if (ExpandHeadsUpOnInlineReply.isEnabled() && mExpandable) { - // it is triggered by the user. - // So, mHasUserChangedExpansion should be marked true. - mHasUserChangedExpansion = true; - } - notifyHeightChanged(/* needsAnimation= */ true); mOnExpandClickListener.onExpandClicked(mEntry, v, nowExpanded); if (shouldLogExpandClickMetric) {
diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRowTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRowTest.java index e8349b0..ed7383c 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRowTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRowTest.java
@@ -1003,21 +1003,6 @@ // THEN assertThat(row.isExpanded()).isFalse(); } - - @Test - @EnableFlags(ExpandHeadsUpOnInlineReply.FLAG_NAME) - public void hasUserChangedExpansion_expandPinned_returnTrue() throws Exception { - // GIVEN - final ExpandableNotificationRow row = mNotificationTestHelper.createRow(); - row.setPinned(true); - - // WHEN - row.expandNotification(); - - // THEN - assertThat(row.hasUserChangedExpansion()).isTrue(); - } - @Test public void onDisappearAnimationFinished_shouldSetFalse_headsUpAnimatingAway() throws Exception {