302a7d905cd05e7e287f084557f947dfaf794869 - android_frameworks_base

commit	302a7d905cd05e7e287f084557f947dfaf794869	[log] [tgz]
author	mattgilbride <mattgilbride@google.com>	Thu Dec 01 16:27:09 2022 +0000
committer	mattgilbride <mattgilbride@google.com>	Fri Dec 02 16:43:55 2022 +0000
tree	83074d5397e1f5d806f2369dee2edc4ab983bc0f
parent	bd3b879b2d7cbd7ba9709889403575611deb67ea [diff]

SimpleManualPermissionEnforcementDetector: conditional ERROR level incident

Use the new information available in @PermissionMethod to raise an
ERROR level incident if we are confident that migrating to
@EnforcePermission is not behavior changing:
 - the called PermissionMethod returns void, indicating it *enforces*
   that PackageManager.PERMISSION_GRANTED is true
 - the called PermissionMethod is annotated orSelf = true, meaning it
   passes of the calling process OR the current process has the
   permission

Bug: 232058525
Test: SimpleManualPermissionEnforcementDetectorTest
Change-Id: Ic4be3d06d6b6446ee81560a6eda7bf9249db1f4c

tools/lint/common/src/main/java/com/google/android/lint/PermissionMethodUtils.kt[diff]
tools/lint/global/checks/src/main/java/com/google/android/lint/aidl/EnforcePermissionFix.kt[diff]
tools/lint/global/checks/src/main/java/com/google/android/lint/aidl/SimpleManualPermissionEnforcementDetector.kt[diff]
tools/lint/global/checks/src/test/java/com/google/android/lint/aidl/SimpleManualPermissionEnforcementDetectorTest.kt[diff]
tools/lint/global/checks/src/test/java/com/google/android/lint/aidl/Stubs.kt[diff]

5 files changed