commit 0a8c907f68d2913bfb7c160c9d481d65443fc1fd
author Andy Hung <hunga@google.com> Thu Dec 10 21:56:01 2020 -0800
committer Andy Hung <hunga@google.com> Thu Dec 10 22:08:04 2020 -0800
tree bf8cff34550280f6ad70a342cceefc0dc24fcd63
parent 7db7b68b9daa6e8ac10b023c032562c466a0dc7e

Midi: Use exceptionCode instead of transactionError

Use of binder::Status exceptionCode is more reliable than
transactionError, especially when calling a Java service.

Test: builds
Bug: 175361278
Change-Id: Iaafb1007f07c7abc22985f0d63f23a0358d6b194

media/native/midi/amidi.cpp

diff --git a/media/native/midi/amidi.cpp b/media/native/midi/amidi.cpp
index 35c4d42..923377c 100644
--- a/media/native/midi/amidi.cpp
+++ b/media/native/midi/amidi.cpp
@@ -131,7 +131,7 @@
     MidiDeviceInfo deviceInfo;
     Status txResult = device->server->getDeviceInfo(&deviceInfo);
     if (!txResult.isOk()) {
-        ALOGE("AMIDI_getDeviceInfo transaction error: %d", txResult.transactionError());
+        ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
         return AMEDIA_ERROR_UNKNOWN;
     }
 
@@ -253,7 +253,7 @@
             ? device->server->openOutputPort(portToken, portNumber, &ufd)
             : device->server->openInputPort(portToken, portNumber, &ufd);
     if (!txResult.isOk()) {
-        ALOGE("AMIDI_openPort transaction error: %d", txResult.transactionError());
+        ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
         return AMEDIA_ERROR_UNKNOWN;
     }
 
@@ -282,7 +282,7 @@
 
     Status txResult = port->device->server->closePort(port->binderToken);
     if (!txResult.isOk()) {
-        ALOGE("Transaction error closing MIDI port:%d", txResult.transactionError());
+        ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
     }
 
     delete port;