Merge "Do not recycle HeadsUpManagerPhone objects" into main
diff --git a/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt b/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt
index 32530d6..6e4038d 100644
--- a/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt
+++ b/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt
@@ -40,6 +40,7 @@
import com.android.systemui.statusbar.notification.shared.NotificationMinimalismPrototype
import com.android.systemui.statusbar.notification.shared.NotificationsHeadsUpRefactor
import com.android.systemui.statusbar.notification.shared.NotificationsLiveDataStoreRefactor
+import com.android.systemui.statusbar.notification.shared.NotificationThrottleHun
import com.android.systemui.statusbar.notification.shared.PriorityPeopleSection
import javax.inject.Inject
@@ -59,6 +60,7 @@
NotificationAvalancheSuppression.token dependsOn VisualInterruptionRefactor.token
PriorityPeopleSection.token dependsOn SortBySectionTimeFlag.token
NotificationMinimalismPrototype.token dependsOn NotificationsHeadsUpRefactor.token
+ NotificationsHeadsUpRefactor.token dependsOn NotificationThrottleHun.token
// SceneContainer dependencies
SceneContainerFlag.getFlagDependencies().forEach { (alpha, beta) -> alpha dependsOn beta }
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/HeadsUpManagerPhone.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/HeadsUpManagerPhone.java
index b2035e1..25d9cc7 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/HeadsUpManagerPhone.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/HeadsUpManagerPhone.java
@@ -117,7 +117,7 @@
@Override
public HeadsUpEntryPhone acquire() {
- NotificationsHeadsUpRefactor.assertInLegacyMode();
+ NotificationThrottleHun.assertInLegacyMode();
if (!mPoolObjects.isEmpty()) {
return mPoolObjects.pop();
}
@@ -126,7 +126,7 @@
@Override
public boolean release(@NonNull HeadsUpEntryPhone instance) {
- NotificationsHeadsUpRefactor.assertInLegacyMode();
+ NotificationThrottleHun.assertInLegacyMode();
mPoolObjects.push(instance);
return true;
}
@@ -428,7 +428,7 @@
@NonNull
@Override
protected HeadsUpEntry createHeadsUpEntry(NotificationEntry entry) {
- if (NotificationsHeadsUpRefactor.isEnabled()) {
+ if (NotificationThrottleHun.isEnabled()) {
return new HeadsUpEntryPhone(entry);
} else {
HeadsUpEntryPhone headsUpEntry = mEntryPool.acquire();
@@ -454,7 +454,7 @@
@Override
protected void onEntryRemoved(HeadsUpEntry headsUpEntry) {
super.onEntryRemoved(headsUpEntry);
- if (!NotificationsHeadsUpRefactor.isEnabled()) {
+ if (!NotificationThrottleHun.isEnabled()) {
mEntryPool.release((HeadsUpEntryPhone) headsUpEntry);
}
updateTopHeadsUpFlow();
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/policy/BaseHeadsUpManager.java b/packages/SystemUI/src/com/android/systemui/statusbar/policy/BaseHeadsUpManager.java
index 4bd0f22..3786958 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/policy/BaseHeadsUpManager.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/policy/BaseHeadsUpManager.java
@@ -439,7 +439,7 @@
onEntryRemoved(finalHeadsUpEntry);
// TODO(b/328390331) move accessibility events to the view layer
entry.sendAccessibilityEvent(AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED);
- if (NotificationsHeadsUpRefactor.isEnabled()) {
+ if (NotificationThrottleHun.isEnabled()) {
finalHeadsUpEntry.cancelAutoRemovalCallbacks("removeEntry");
} else {
finalHeadsUpEntry.reset();
@@ -768,7 +768,7 @@
@Nullable private Runnable mCancelRemoveRunnable;
public HeadsUpEntry() {
- NotificationsHeadsUpRefactor.assertInLegacyMode();
+ NotificationThrottleHun.assertInLegacyMode();
}
public HeadsUpEntry(NotificationEntry entry) {
@@ -779,7 +779,7 @@
/** Attach a NotificationEntry. */
public void setEntry(@NonNull final NotificationEntry entry) {
- NotificationsHeadsUpRefactor.assertInLegacyMode();
+ NotificationThrottleHun.assertInLegacyMode();
setEntry(entry, createRemoveRunnable(entry));
}
@@ -976,7 +976,7 @@
}
public void reset() {
- NotificationsHeadsUpRefactor.assertInLegacyMode();
+ NotificationThrottleHun.assertInLegacyMode();
cancelAutoRemovalCallbacks("reset()");
mEntry = null;
mRemoveRunnable = null;