commit fcf15bf486b4324d00d1f9d8c7b8f27a6b1db0a1
author François Gaffie <francois.gaffie@renault.com> Wed Feb 15 11:37:43 2023 +0100
committer Eric Laurent <elaurent@google.com> Thu Jun 22 16:23:33 2023 +0200
tree ad3578a93a144b9a965e14c2ef64a79989fa0d38
parent b8551f621e66c052bdda8b42e76c42bd482a36af

audioflinger: effect: fix deadlock after dumpsys

Bug: 268441977
Test: add a device effect, call dumpsys twice, proxy is marked as "might
be deadlocked"

This CL fixes lock/unlock on the wrong lock

Change-Id: I6923e891a0d87a1be87edbaf44baa554ee729adb
Signed-off-by: François Gaffie <francois.gaffie@renault.com>

services/audioflinger/Effects.cpp

diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 25c8ac8..6716d73 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -3485,7 +3485,7 @@
     }
 
     if (locked) {
-        mLock.unlock();
+        mProxyLock.unlock();
     }
 }