commit f698ff2d177d62a714d452ce63430606738a4190
author Mikhail Naganov <mnaganov@google.com> Tue Mar 31 10:07:29 2020 -0700
committer Mikhail Naganov <mnaganov@google.com> Tue Mar 31 22:06:58 2020 +0000
tree e53e0cbf41ce80cc85b73f6495323207899c86c9
parent 1cfbd0a8a1083af1a7afeb19b2bdc0d757d9daf5

Fix uninitialized variable use in Effects.cpp

Initialize variable 'strategy' in
AudioFlinger::EffectBase::updatePolicyState.
Found by clang-tidy.

Bug: 152526318
Test: m
Change-Id: I5aad916a9873122eed0bb8e40bb26d677f338b16

services/audioflinger/Effects.cpp

diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 81815f8..55f2952 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -29,6 +29,7 @@
 #include <system/audio_effects/effect_visualizer.h>
 #include <audio_utils/channels.h>
 #include <audio_utils/primitives.h>
+#include <media/AudioCommonTypes.h>
 #include <media/AudioContainers.h>
 #include <media/AudioEffect.h>
 #include <media/AudioDeviceTypeAddr.h>
@@ -213,7 +214,7 @@
     bool doEnable = false;
     bool enabled = false;
     audio_io_handle_t io = AUDIO_IO_HANDLE_NONE;
-    uint32_t strategy;
+    uint32_t strategy = PRODUCT_STRATEGY_NONE;
 
     {
         Mutex::Autolock _l(mLock);