commit ee71ebd1d28a68e3b630a6c1499a3b36e8141089
author Greg Kaiser <gkaiser@google.com> Tue Nov 09 07:37:38 2021 -0800
committer Greg Kaiser <gkaiser@google.com> Tue Nov 09 21:45:30 2021 +0000
tree 3802532aafb468d8a2a106ed6778dbc4b60e1a37
parent 3de1764659f5d05897daf84e1bf43ad44ef29a74

audioflinger: Initialize field in constructor

We want to avoid using mThreadType uninitialized.

Test: TreeHugger
Bug: 204742569
Change-Id: I4b95139f1f1d9e4efac51a57be3729d2fd75204b

services/audioflinger/Effects.h

diff --git a/services/audioflinger/Effects.h b/services/audioflinger/Effects.h
index daed5fc..5ebf483 100644
--- a/services/audioflinger/Effects.h
+++ b/services/audioflinger/Effects.h
@@ -565,6 +565,12 @@
             : mChain(owner)
             , mThread(thread)
             , mAudioFlinger(*gAudioFlinger) {
+            sp<ThreadBase> base = thread.promote();
+            if (base != nullptr) {
+                mThreadType = base->type();
+            } else {
+                mThreadType = ThreadBase::MIXER;  // assure a consistent value.
+            }
         }
 
         status_t createEffectHal(const effect_uuid_t *pEffectUuid,