commit eaf9d9c7ef084db451ed200594e5f15b5966fea8
author Jaideep Sharma <quic_jaidshar@quicinc.com> Fri May 13 15:15:27 2022 +0530
committer Andy Hung <hunga@google.com> Tue May 17 15:51:46 2022 -0700
tree 305b2cdefef6213b1fb4e9cd56d7b91ca5ad7ca4
parent 065fb0f576532edc127abe67dd917783fae84395

MediaUtils: Dump HAL pids in Timecheck abort message

Dump list of HAL pids in abort message of tombstone by making sure
HAL information is not missed from tombstones.

Test: instrumented timeout, check tombstone
Bug: 232883977
Change-Id: I7a68a3facdc956da5bf0222c400e7229980adb4f

media/utils/TimeCheck.cpp

diff --git a/media/utils/TimeCheck.cpp b/media/utils/TimeCheck.cpp
index 75a1b22..0848eb3 100644
--- a/media/utils/TimeCheck.cpp
+++ b/media/utils/TimeCheck.cpp
@@ -189,15 +189,18 @@
     // Generate audio HAL processes tombstones and allow time to complete
     // before forcing restart
     std::vector<pid_t> pids = TimeCheck::getAudioHalPids();
+    std::string halPids = "HAL pids [ ";
     if (pids.size() != 0) {
         for (const auto& pid : pids) {
             ALOGI("requesting tombstone for pid: %d", pid);
+            halPids.append(std::to_string(pid)).append(" ");
             sigqueue(pid, DEBUGGER_SIGNAL, {.sival_int = 0});
         }
         sleep(1);
     } else {
         ALOGI("No HAL process pid available, skipping tombstones");
     }
+    halPids.append("]");
 
     LOG_EVENT_STRING(LOGTAG_AUDIO_BINDER_TIMEOUT, tag.c_str());
 
@@ -206,6 +209,7 @@
             .append(tag)
             .append(" scheduled ").append(formatTime(startTime))
             .append(" on thread ").append(std::to_string(tid)).append("\n")
+            .append(halPids).append("\n")
             .append(summary);
 
     // Note: LOG_ALWAYS_FATAL limits the size of the string - per log/log.h: