commit e5b052ea1209bf0ced35e82a0096bf799011499e
author Yi Kong <yikong@google.com> Thu Mar 01 17:56:44 2018 -0500
committer Yi Kong <yikong@google.com> Thu Mar 01 17:56:44 2018 -0500
tree 4839a961e35479374078edb02d832e2938df2f4c
parent 853996e7b28fcb8707a15f70eb9c3cadd47943f0

Remove unreachable condition

Comparison of unsigned enum expression < 0 is always false. Fixes
tautological-unsigned-enum-zero-compare warning.

Bug: 72331526
Test: m
Change-Id: I9b4aa103ed64d3d08d1e36abbd8f3bf960cdf5d4

media/libaudioclient/ToneGenerator.cpp

diff --git a/media/libaudioclient/ToneGenerator.cpp b/media/libaudioclient/ToneGenerator.cpp
index cfb5be6..5338059 100644
--- a/media/libaudioclient/ToneGenerator.cpp
+++ b/media/libaudioclient/ToneGenerator.cpp
@@ -1029,7 +1029,7 @@
     bool lResult = false;
     status_t lStatus;
 
-    if ((toneType < 0) || (toneType >= NUM_TONES))
+    if (toneType >= NUM_TONES)
         return lResult;
 
     toneType = getToneForRegion(toneType);