commit e048e90967aa52e01b6b3ca445e4ade75c0dc878
author Chih-Chung Chang <chihchung@google.com> Mon Aug 01 12:15:59 2011 +0800
committer Chih-Chung Chang <chihchung@google.com> Tue Aug 02 19:34:13 2011 +0800
tree a45d41b8acb38e8570fa8fa2f5ca6598f7f14324
parent 2d461d443d4d0a35acb9cfd49cafad8941b17a0b

Remove PreviewLocalRenderer (simplify the code).

Change-Id: I1f04e591cd0a33eb70bd93d5600aba12e727386e

libvideoeditor/lvpp/PreviewPlayer.cpp

diff --git a/libvideoeditor/lvpp/PreviewPlayer.cpp b/libvideoeditor/lvpp/PreviewPlayer.cpp
index f2b82d9..0f04c0a 100755
--- a/libvideoeditor/lvpp/PreviewPlayer.cpp
+++ b/libvideoeditor/lvpp/PreviewPlayer.cpp
@@ -72,102 +72,6 @@
     PreviewPlayerEvent &operator=(const PreviewPlayerEvent &);
 };
 
-
-struct PreviewLocalRenderer : public PreviewPlayerRenderer {
-
-    static PreviewLocalRenderer* initPreviewLocalRenderer (
-            bool previewOnly,
-            OMX_COLOR_FORMATTYPE colorFormat,
-            const sp<Surface> &surface,
-            size_t displayWidth, size_t displayHeight,
-            size_t decodedWidth, size_t decodedHeight,
-            int32_t rotationDegrees = 0)
-    {
-        PreviewLocalRenderer* mLocalRenderer = new
-            PreviewLocalRenderer(
-                previewOnly,
-                colorFormat,
-                surface,
-                displayWidth, displayHeight,
-                decodedWidth, decodedHeight,
-                rotationDegrees);
-
-        if ( mLocalRenderer->init(previewOnly,
-                 colorFormat, surface,
-                 displayWidth, displayHeight,
-                 decodedWidth, decodedHeight,
-                 rotationDegrees) != OK )
-        {
-            delete mLocalRenderer;
-            return NULL;
-        }
-        return mLocalRenderer;
-    }
-
-    virtual void render(MediaBuffer *buffer) {
-        render((const uint8_t *)buffer->data() + buffer->range_offset(),
-               buffer->range_length());
-    }
-
-    void render(const void *data, size_t size) {
-        mTarget->render(data, size, NULL);
-    }
-    void render() {
-        mTarget->renderYV12();
-    }
-    void getBuffer(uint8_t **data, size_t *stride) {
-        mTarget->getBufferYV12(data, stride);
-    }
-
-protected:
-    virtual ~PreviewLocalRenderer() {
-        delete mTarget;
-        mTarget = NULL;
-    }
-
-private:
-    PreviewRenderer *mTarget;
-
-    PreviewLocalRenderer(
-            bool previewOnly,
-            OMX_COLOR_FORMATTYPE colorFormat,
-            const sp<Surface> &surface,
-            size_t displayWidth, size_t displayHeight,
-            size_t decodedWidth, size_t decodedHeight,
-            int32_t rotationDegrees = 0)
-        : mTarget(NULL) {
-    }
-
-
-    int init(
-            bool previewOnly,
-            OMX_COLOR_FORMATTYPE colorFormat,
-            const sp<Surface> &surface,
-            size_t displayWidth, size_t displayHeight,
-            size_t decodedWidth, size_t decodedHeight,
-            int32_t rotationDegrees = 0);
-
-    PreviewLocalRenderer(const PreviewLocalRenderer &);
-    PreviewLocalRenderer &operator=(const PreviewLocalRenderer &);;
-};
-
-int PreviewLocalRenderer::init(
-        bool previewOnly,
-        OMX_COLOR_FORMATTYPE colorFormat,
-        const sp<Surface> &surface,
-        size_t displayWidth, size_t displayHeight,
-        size_t decodedWidth, size_t decodedHeight,
-        int32_t rotationDegrees) {
-
-    mTarget = PreviewRenderer::CreatePreviewRenderer (
-            colorFormat, surface, displayWidth, displayHeight,
-            decodedWidth, decodedHeight, rotationDegrees);
-    if (mTarget == M4OSA_NULL) {
-        return UNKNOWN_ERROR;
-    }
-    return OK;
-}
-
 PreviewPlayer::PreviewPlayer()
     : PreviewPlayerBase(),
       mCurrFramingEffectIndex(0)   ,
@@ -232,8 +136,7 @@
         mResizedVideoBuffer = NULL;
     }
 
-    mVideoRenderer.clear();
-    mVideoRenderer = NULL;
+    delete mVideoRenderer;
 }
 
 void PreviewPlayer::cancelPlayerEvents(bool keepBufferingGoing) {
@@ -768,12 +671,12 @@
         // allocate their buffers in local address space.
         if(mVideoRenderer == NULL) {
 
-            mVideoRenderer = PreviewLocalRenderer:: initPreviewLocalRenderer (
-                false,  // previewOnly
+            mVideoRenderer = PreviewRenderer::CreatePreviewRenderer(
                 OMX_COLOR_FormatYUV420Planar,
                 mSurface,
                 mOutputVideoWidth, mOutputVideoHeight,
-                mOutputVideoWidth, mOutputVideoHeight);
+                mOutputVideoWidth, mOutputVideoHeight,
+                0);
 
             if ( mVideoRenderer == NULL )
             {
@@ -1220,7 +1123,7 @@
 
     if (mVideoRenderer != NULL) {
         LOGV("mVideoRenderer CALL render()");
-        mVideoRenderer->render();
+        mVideoRenderer->renderYV12();
     }
 
     if (mLastVideoBuffer) {
@@ -1510,7 +1413,7 @@
     uint8_t* outBuffer;
     size_t outBufferStride = 0;
 
-    mVideoRenderer->getBuffer(&outBuffer, &outBufferStride);
+    mVideoRenderer->getBufferYV12(&outBuffer, &outBufferStride);
 
     bufferOffset = index*frameSize;
     inBuffer = (M4OSA_UInt8 *)mVideoBuffer->data()+
@@ -1712,7 +1615,8 @@
 
     postProcessParams.overlayFrameRGBBuffer = mFrameRGBBuffer;
     postProcessParams.overlayFrameYUVBuffer = mFrameYUVBuffer;
-    mVideoRenderer->getBuffer(&(postProcessParams.pOutBuffer), &(postProcessParams.outBufferStride));
+    mVideoRenderer->getBufferYV12(&(postProcessParams.pOutBuffer),
+        &(postProcessParams.outBufferStride));
     err = applyEffectsAndRenderingMode(&postProcessParams, mReportedWidth, mReportedHeight);
 
     return err;