commit d21c46b3cc97497be689c344046b51cba00aa4b5
author Yin-Chia Yeh <yinchiayeh@google.com> Tue Oct 10 11:59:46 2017 -0700
committer Yin-Chia Yeh <yinchiayeh@google.com> Tue Oct 10 11:59:46 2017 -0700
tree 0dac87e317330453342de707e8c0b8b76b62c9da
parent 16f2c1559c5722a6cd69fef3c17dc5756ba73fe6

Camera: fix use after freed error

Test: static analyzer warning is fixed
Bug: 67606758
Change-Id: I563b581755dc874d1c19f6875b161f7b8912229d

camera/ndk/impl/ACameraDevice.cpp

diff --git a/camera/ndk/impl/ACameraDevice.cpp b/camera/ndk/impl/ACameraDevice.cpp
index 229b159..79a3e3a 100644
--- a/camera/ndk/impl/ACameraDevice.cpp
+++ b/camera/ndk/impl/ACameraDevice.cpp
@@ -941,7 +941,6 @@
                     ACaptureRequest* request = allocateACaptureRequest(requestSp);
                     (*onFail)(context, session.get(), request, failure);
                     freeACaptureRequest(request);
-                    delete failure;
                     break;
                 }
                 case kWhatCaptureSeqEnd:

camera/ndk/impl/ACameraDevice.h

diff --git a/camera/ndk/impl/ACameraDevice.h b/camera/ndk/impl/ACameraDevice.h
index c566cd2..c0766c5 100644
--- a/camera/ndk/impl/ACameraDevice.h
+++ b/camera/ndk/impl/ACameraDevice.h
@@ -41,7 +41,7 @@
 
 namespace android {
 
-// Wrap ACameraCaptureFailure so it can be ref-counter
+// Wrap ACameraCaptureFailure so it can be ref-counted
 struct CameraCaptureFailure : public RefBase, public ACameraCaptureFailure {};
 
 class CameraDevice final : public RefBase {