commit c9d24d07ec243a183993595a6902c0687a937ddc
author Yunlian Jiang <yunlian@google.com> Tue Nov 22 21:03:12 2016 -0800
committer George Burgess IV <gbiv@google.com> Tue Nov 22 21:03:12 2016 -0800
tree ff96676dc3c041071de242df7f86346978acfb10
parent 76321a335ccd1e810221e5ffbae2f045d4f397fa

fix warning: Dereference of null pointer

This fixes the static analyzer warning
warning: Dereference of null pointer (loaded from variable 'devices')

Bug: None
Test: The warning is gone.
Change-Id: If0d2649bf0a90a403013c4af1b94814357b792c2

services/audioflinger/AudioFlinger.cpp

diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index c6d4fe3..b7b669b 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -1908,7 +1908,7 @@
               config->channel_mask,
               flags);
 
-    if (*devices == AUDIO_DEVICE_NONE) {
+    if (devices == NULL || *devices == AUDIO_DEVICE_NONE) {
         return BAD_VALUE;
     }