commit bfb487a62500acbabebe13e0489137e58a211b2f
author Greg Kaiser <gkaiser@google.com> Wed May 08 06:04:48 2019 -0700
committer Greg Kaiser <gkaiser@google.com> Wed May 08 06:04:48 2019 -0700
tree 6cf39dd9f7cea0bbd5922a5ca3a28fa46d613c24
parent 3350096bf8e52b2d96f7b7ba95642d92c05e8f09

media: Fix MediaCodesXmlParser Result bug

In the constructor, we want to assign our new error string to
the struct member, instead of to the function argument.

Bug: 129710438
Test: TreeHugger
Change-Id: Id3a16fb048b3f5db97e455f6baaaec153b6bf6f0

media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp

diff --git a/media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp b/media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp
index 6a1b9a8..b1e5fbf 100644
--- a/media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp
+++ b/media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp
@@ -148,7 +148,7 @@
             : mStatus(s),
               mError(error) {
             if (error.empty() && s) {
-                error = "Failed (" + std::string(asString(s)) + ")";
+                mError = "Failed (" + std::string(asString(s)) + ")";
             }
         }
         operator status_t() const { return mStatus; }