commit b8551f621e66c052bdda8b42e76c42bd482a36af
author François Gaffie <francois.gaffie@renault.com> Wed Feb 15 11:36:35 2023 +0100
committer Eric Laurent <elaurent@google.com> Thu Jun 22 16:23:06 2023 +0200
tree 955e3a127fff997f3ae63c584f265e6288803499
parent 82a187c8807822fb9c71f7b8b89d803a1ca69452

audioeffect: fix segfault on device effect configuration

Bug: 268441977
Test: add a default device effect, launch a use case involging it

When calling configure for a device effect, mMaxDisableWaitCnt is
computed from framecount function call as divider. It is initialized
to 0 for DeviceEffectProxy, thus leading to segfault

Change-Id: Id5c62c3100e17ea3e142ad3ef3e8838a7bc3d71c
Signed-off-by: François Gaffie <francois.gaffie@renault.com>

services/audioflinger/Effects.cpp

diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 822ea93..25c8ac8 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -1005,8 +1005,9 @@
     // mConfig.outputCfg.buffer.frameCount cannot be zero.
     mMaxDisableWaitCnt = (uint32_t)std::max(
             (uint64_t)1, // mMaxDisableWaitCnt must be greater than zero.
-            (uint64_t)MAX_DISABLE_TIME_MS * mConfig.outputCfg.samplingRate
-                / ((uint64_t)1000 * mConfig.outputCfg.buffer.frameCount));
+            (uint64_t)mConfig.outputCfg.buffer.frameCount == 0 ? 1
+                : (MAX_DISABLE_TIME_MS * mConfig.outputCfg.samplingRate
+                / ((uint64_t)1000 * mConfig.outputCfg.buffer.frameCount)));
 
 exit:
     // TODO: consider clearing mConfig on error.