commit b851b3cc2f43fa7bab553002867956fa5670b50d
author Shunkai Yao <yaoshunkai@google.com> Mon Feb 27 22:50:00 2023 +0000
committer Shunkai Yao <yaoshunkai@google.com> Mon Feb 27 23:49:04 2023 +0000
tree 31a5d5381b1525e4f80fe60664cf78e7671ebece
parent 692bb92e4da5f37ea2e0d36b3e44235b0eae76df

[AIDL CTS] Fix visualizer cts issue with AIDL effects

1. Mapping VISUALIZER_CMD_CAPTURE command correctly with handler
2. Capture silent data when inactive Visualizer receive capture command

Bug: 270155119
Test: enable aidl and
atest CtsMediaAudioTestCases:android.media.audio.cts.VisualizerTest

Change-Id: Ic37e4c7e0b66af662381a187064974d56e5cc48e

media/libaudiohal/impl/EffectConversionHelperAidl.cpp

diff --git a/media/libaudiohal/impl/EffectConversionHelperAidl.cpp b/media/libaudiohal/impl/EffectConversionHelperAidl.cpp
index dc47d67..dcc9127 100644
--- a/media/libaudiohal/impl/EffectConversionHelperAidl.cpp
+++ b/media/libaudiohal/impl/EffectConversionHelperAidl.cpp
@@ -60,8 +60,7 @@
                 {EFFECT_CMD_SET_INPUT_DEVICE, &EffectConversionHelperAidl::handleSetDevice},
                 {EFFECT_CMD_SET_VOLUME, &EffectConversionHelperAidl::handleSetVolume},
                 {EFFECT_CMD_OFFLOAD, &EffectConversionHelperAidl::handleSetOffload},
-                {EFFECT_CMD_FIRST_PROPRIETARY, &EffectConversionHelperAidl::handleFirstPriority},
-                // Only visualizer support these commands
+                // Only visualizer support these commands, reuse of EFFECT_CMD_FIRST_PROPRIETARY
                 {VISUALIZER_CMD_CAPTURE, &EffectConversionHelperAidl::handleVisualizerCapture},
                 {VISUALIZER_CMD_MEASURE, &EffectConversionHelperAidl::handleVisualizerMeasure}};
 
@@ -278,18 +277,6 @@
     return *static_cast<int32_t*>(pReplyData) = OK;
 }
 
-status_t EffectConversionHelperAidl::handleFirstPriority(uint32_t cmdSize __unused,
-                                                         const void* pCmdData __unused,
-                                                         uint32_t* replySize, void* pReplyData) {
-    if (!replySize || !pReplyData) {
-        ALOGE("%s parameter invalid %p %p", __func__, replySize, pReplyData);
-        return BAD_VALUE;
-    }
-
-    // TODO to be implemented
-    return OK;
-}
-
 status_t EffectConversionHelperAidl::handleVisualizerCapture(uint32_t cmdSize __unused,
                                                              const void* pCmdData __unused,
                                                              uint32_t* replySize,