commit b60d788a3ff857df6571b265be268508527ef327
author Andy Hung <hunga@google.com> Tue Apr 10 16:44:53 2018 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Tue Apr 10 16:44:53 2018 +0000
tree a5a002e2c9d2aca046a2d85fa4df6f6c58db833b
parent 8a21f4aaf9e7eece4f6b8016b4c69c243adac4a3
parent 361155ac670d6e528309525e7737e9e2da4046ff

Merge "EffectReverb: Fix unsigned integer overflow" into pi-dev

media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp

diff --git a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
index 0630285..e1c03f9 100644
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@@ -1966,7 +1966,8 @@
 
     if (pContext->bEnabled == LVM_FALSE) {
         if (pContext->SamplesToExitCount > 0) {
-            pContext->SamplesToExitCount -= outBuffer->frameCount;
+            // signed - unsigned will trigger integer overflow if result becomes negative.
+            pContext->SamplesToExitCount -= (ssize_t)outBuffer->frameCount;
         } else {
             status = -ENODATA;
         }