commit b3fc688608b4a36c432edb97164bc0eaba344ddf
author Andy Hung <hunga@google.com> Mon Aug 19 19:03:55 2024 -0700
committer Andy Hung <hunga@google.com> Mon Aug 19 19:07:51 2024 -0700
tree ec4e6f4799a2c6a974106215b771ce0f14da16f2
parent 950c9e7bfd0ae5005747edab26ccf0b1192c49be

AudioFlinger: Do not create direct secondary output tracks

Test: Live Caption
Flag: EXEMPT bugfix
Bug: 359862350
Change-Id: Ie0b7c1b2a5aaf02f71da7decd0e9df534fdd0a57

services/audioflinger/AudioFlinger.cpp

diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index 32ca690..77b342a 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -4015,8 +4015,12 @@
         // TODO: We could check compatibility of the secondaryThread with the PatchTrack
         // for fast usage: thread has fast mixer, sample rate matches, etc.;
         // for now, we exclude fast tracks by removing the Fast flag.
+        constexpr audio_output_flags_t kIncompatiblePatchTrackFlags =
+                static_cast<audio_output_flags_t>(AUDIO_OUTPUT_FLAG_FAST
+                        | AUDIO_OUTPUT_FLAG_DIRECT | AUDIO_OUTPUT_FLAG_COMPRESS_OFFLOAD);
+
         const audio_output_flags_t outputFlags =
-                (audio_output_flags_t)(track->getOutputFlags() & ~AUDIO_OUTPUT_FLAG_FAST);
+                (audio_output_flags_t)(track->getOutputFlags() & ~kIncompatiblePatchTrackFlags);
         sp<IAfPatchTrack> patchTrack = IAfPatchTrack::create(secondaryThread,
                                                        track->streamType(),
                                                        track->sampleRate(),