commit ae692fb14787ef2c07f41d4ed0e84bf7e0b943cb
author Greg Kaiser <gkaiser@google.com> Thu Feb 10 07:32:06 2022 -0800
committer Greg Kaiser <gkaiser@google.com> Thu Feb 10 07:32:06 2022 -0800
tree d7bd420400c5dbf987a6ad8d9e54d3eeacd275a6
parent e741f50bc9219af4b9bd83c536a4363d1cd76bca

Avoid extra string creation

We're calling a function that takes a const reference to a
std::string.  When passing the result of c_str(), it forces
the creation of a new std::string object.  By directly passing
a const reference our already created std::string, we avoid this.

Test: TreeHugger
Bug: 196432585
Change-Id: I40bc8ebd0cf59452a59ae2a350ddb2542eb5b3b0

services/camera/libcameraservice/common/CameraProviderManager.cpp

diff --git a/services/camera/libcameraservice/common/CameraProviderManager.cpp b/services/camera/libcameraservice/common/CameraProviderManager.cpp
index 1b8863a..c337eda 100644
--- a/services/camera/libcameraservice/common/CameraProviderManager.cpp
+++ b/services/camera/libcameraservice/common/CameraProviderManager.cpp
@@ -152,7 +152,7 @@
                     __FUNCTION__);
             return res;
         }
-        addAidlProviderLocked(aidlServiceName.c_str());
+        addAidlProviderLocked(aidlServiceName);
     }
     return OK;
 }