commit ac9858be02edea7770ab3bb27d1cc15e4640fb26
author Mikhail Naganov <mnaganov@google.com> Fri Jun 15 13:12:37 2018 -0700
committer Mikhail Naganov <mnaganov@google.com> Mon Jul 09 14:01:15 2018 -0700
tree ff0385983e0302f6f81a902d0e63b680d6c83ff5
parent 908c7d77355ae2c63a179a4ebfce69b7a6d31e3f

Use and test patch utilities from system/audio.h

Use `audio_patch_is_valid` function.

Add basic tests for the following functions:
  audio_patch_is_valid
  audio_port_config_has_hw_av_sync
  audio_patches_are_equal

Bug: 63901775
Test: systemaudio_tests
Change-Id: I378ab544e4148fda0dd7b9520d6fd57ff01cb34b

services/audioflinger/PatchPanel.cpp

diff --git a/services/audioflinger/PatchPanel.cpp b/services/audioflinger/PatchPanel.cpp
index 42a5a90..0caa0af 100644
--- a/services/audioflinger/PatchPanel.cpp
+++ b/services/audioflinger/PatchPanel.cpp
@@ -110,9 +110,7 @@
     status_t status = NO_ERROR;
     audio_patch_handle_t halHandle = AUDIO_PATCH_HANDLE_NONE;
 
-    if (patch->num_sources == 0 || patch->num_sources > AUDIO_PATCH_PORTS_MAX ||
-            (patch->num_sinks == 0 && patch->num_sources != 2) ||
-            patch->num_sinks > AUDIO_PATCH_PORTS_MAX) {
+    if (!audio_patch_is_valid(patch) || (patch->num_sinks == 0 && patch->num_sources != 2)) {
         return BAD_VALUE;
     }
     // limit number of sources to 1 for now or 2 sources for special cross hw module case.