commit abbdeb107c693284bdd41389648aa19870888676
author Yanqiang Fan <yanqiang.fan@mediatek.com> Tue Oct 22 15:06:22 2024 +0800
committer Muga Chi <muga.chi@mediatek.corp-partner.google.com> Wed Oct 23 01:24:34 2024 +0000
tree 63c6a148abc8546f629b5a21860f6995b2fd6b7a
parent e58ae2915643fd115532e1fb31dbe90dc0c266fe

codec2: Fix VideoEncoderRoiTest cts failure

Corrected the assignment of rect to ensure proper region of interest
configuration, preventing invalid rects and fixing the test failure.

Test:run cts --abi arm64-v8a -m CtsVideoCodecTestCases -t android.videocodec.ctsVideoEncoderRoiTest --log-level-display INFO

Bug: 374920078

Change-Id: Ia0ab535c2671ce0f85688ec028c53dfd5d922cad

media/codec2/sfplugin/CCodecConfig.cpp

diff --git a/media/codec2/sfplugin/CCodecConfig.cpp b/media/codec2/sfplugin/CCodecConfig.cpp
index a943626..897a696 100644
--- a/media/codec2/sfplugin/CCodecConfig.cpp
+++ b/media/codec2/sfplugin/CCodecConfig.cpp
@@ -1907,7 +1907,7 @@
                         bottom = c2_min(bottom, height);
                         if (right > left && bottom > top) {
                             C2Rect rect(right - left, bottom - top);
-                            rect.at(left, top);
+                            rect = rect.at(left, top);
                             c2QpOffsetRects.push_back(C2QpOffsetRectStruct(rect, offset));
                         } else {
                             ALOGE("Rects configuration %s is not valid.", box);