commit a027bf7877a49132eb7c067cb6425bca6ff87c4b
author Wonsik Kim <wonsik@google.com> Mon May 09 19:45:57 2022 -0700
committer Wonsik Kim <wonsik@google.com> Mon May 09 19:45:57 2022 -0700
tree d7293bf3acbdc2c3903c35a5aa2814a3026186fb
parent d8bef59f6d97751a0e0031d792dd922e7393fc44

CCodec: request initial input buffers after start complete callback

Bug: 229655684
Test: atest android.media.encoder.cts.VideoEncoderTest
Change-Id: I66e3f62270450742072f0490c16acf0c49d59722

media/codec2/sfplugin/CCodec.cpp

diff --git a/media/codec2/sfplugin/CCodec.cpp b/media/codec2/sfplugin/CCodec.cpp
index 8783c2c..19bb206 100644
--- a/media/codec2/sfplugin/CCodec.cpp
+++ b/media/codec2/sfplugin/CCodec.cpp
@@ -1826,15 +1826,13 @@
         return;
     }
 
-    err2 = mChannel->requestInitialInputBuffers();
-
-    if (err2 != OK) {
-        ALOGE("Initial request for Input Buffers failed");
-        mCallback->onError(err2,ACTION_CODE_FATAL);
-        return;
-    }
     mCallback->onStartCompleted();
 
+    err2 = mChannel->requestInitialInputBuffers();
+    if (err2 != OK) {
+        ALOGE("Initial request for Input Buffers failed");
+        mCallback->onError(err2, ACTION_CODE_FATAL);
+    }
 }
 
 void CCodec::initiateShutdown(bool keepComponentAllocated) {
@@ -2128,7 +2126,11 @@
         state->set(RUNNING);
     }
 
-    (void)mChannel->requestInitialInputBuffers();
+    status_t err = mChannel->requestInitialInputBuffers();
+    if (err != OK) {
+        ALOGE("Resume request for Input Buffers failed");
+        mCallback->onError(err, ACTION_CODE_FATAL);
+    }
 }
 
 void CCodec::signalSetParameters(const sp<AMessage> &msg) {