commit 9b5cbdbecd516bdc76d8362e9da12ad6b0f6ae77
author François Gaffie <francois.gaffie@renault.com> Fri May 31 10:36:39 2024 +0200
committer Shunkai Yao <yaoshunkai@google.com> Fri Jul 12 05:31:59 2024 +0000
tree dd8c471e2aea9d40df02b19c4a0943f9b1b5951b
parent 6e7873a71781eb11289ddcb8e4dddab0012a1ca8

Fix device effect instatiation

-configure shall be called before any setParam (device, ...) as it
will open the effect, thus creating the context.
Context shall not be null to handle any setParameters

-Input / Output MQ are invalid if the effect buffer size is 0.

Flag: EXEMPT bugfix
Bug: 329395147
Test: atest CtsMediaAudioTestCase

Change-Id: I13676bc6564b24cf3b8d56e0646dc263599fea35
Signed-off-by: François Gaffie <francois.gaffie@renault.com>

services/audioflinger/Effects.cpp

diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 973b2ab..c46027c 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -3537,12 +3537,12 @@
             mHalEffect = sp<HwAccDeviceEffectModule>::make(mMyCallback,
                     const_cast<effect_descriptor_t *>(&mDescriptor), mMyCallback->newEffectId(),
                     port->id);
+            mHalEffect->configure_l();
             if (audio_is_input_device(mDevice.mType)) {
                 mHalEffect->setInputDevice(mDevice);
             } else {
                 mHalEffect->setDevices({mDevice});
             }
-            mHalEffect->configure_l();
         }
         *handle = new EffectHandle(mHalEffect, nullptr, nullptr, 0 /*priority*/,
                                    mNotifyFramesProcessed);

services/audioflinger/Effects.h

diff --git a/services/audioflinger/Effects.h b/services/audioflinger/Effects.h
index 830fe81..66ec837 100644
--- a/services/audioflinger/Effects.h
+++ b/services/audioflinger/Effects.h
@@ -810,7 +810,10 @@
         audio_channel_mask_t outChannelMask() const override;
         uint32_t outChannelCount() const override;
         audio_channel_mask_t hapticChannelMask() const override { return AUDIO_CHANNEL_NONE; }
-        size_t frameCount() const override  { return 0; }
+        /**
+         * frameCount cannot be zero.
+         */
+        size_t frameCount() const override  { return 1; }
         uint32_t latency() const override  { return 0; }
 
         status_t addEffectToHal(const sp<EffectHalInterface>& effect) override;