commit 8e06263e23b0f44d3a8e2970548a600e6bde3560
author Chong Zhang <chz@google.com> Tue Mar 31 10:56:37 2020 -0700
committer Chong Zhang <chz@google.com> Tue Mar 31 15:52:47 2020 -0700
tree 025ed1f839fc6751fc0015dfbdf689a896effb78
parent 5e76a930b0a7147c0dbd32f0fc1e9cd35baaf705

transcoding: separate client interface from service

Refactor AIDL to separate client interface from service.

Use client listener binder as unique id for client, as multiple
clients could exist for the same pid.

Misc unit testing changes.

bug: 145233472
test: mediatranscodingservice_test, TranscodingClientManager_tests
Change-Id: I8d9522da23163375df8df7822d0f6ae270cff1b4

services/mediatranscoding/MediaTranscodingService.h

diff --git a/services/mediatranscoding/MediaTranscodingService.h b/services/mediatranscoding/MediaTranscodingService.h
index cc69727..785bc4d 100644
--- a/services/mediatranscoding/MediaTranscodingService.h
+++ b/services/mediatranscoding/MediaTranscodingService.h
@@ -25,7 +25,8 @@
 
 using Status = ::ndk::ScopedAStatus;
 using ::aidl::android::media::BnMediaTranscodingService;
-using ::aidl::android::media::ITranscodingServiceClient;
+using ::aidl::android::media::ITranscodingClient;
+using ::aidl::android::media::ITranscodingClientListener;
 using ::aidl::android::media::TranscodingJobParcel;
 using ::aidl::android::media::TranscodingRequestParcel;
 
@@ -41,23 +42,17 @@
 
     static const char* getServiceName() { return "media.transcoding"; }
 
-    Status registerClient(const std::shared_ptr<ITranscodingServiceClient>& in_client,
-                          const std::string& in_opPackageName, int32_t in_clientUid,
-                          int32_t in_clientPid, int32_t* _aidl_return) override;
-
-    Status unregisterClient(int32_t clientId, bool* _aidl_return) override;
+    Status registerClient(
+            const std::shared_ptr<ITranscodingClientListener>& in_listener,
+            const std::string& in_clientName,
+            const std::string& in_opPackageName,
+            int32_t in_clientUid, int32_t in_clientPid,
+            std::shared_ptr<ITranscodingClient>* _aidl_return) override;
 
     Status getNumOfClients(int32_t* _aidl_return) override;
 
-    Status submitRequest(int32_t in_clientId, const TranscodingRequestParcel& in_request,
-                         TranscodingJobParcel* out_job, int32_t* _aidl_return) override;
-
-    Status cancelJob(int32_t in_clientId, int32_t in_jobId, bool* _aidl_return) override;
-
-    Status getJobWithId(int32_t in_jobId, TranscodingJobParcel* out_job,
-                        bool* _aidl_return) override;
-
-    virtual inline binder_status_t dump(int /*fd*/, const char** /*args*/, uint32_t /*numArgs*/);
+    virtual inline binder_status_t dump(
+            int /*fd*/, const char** /*args*/, uint32_t /*numArgs*/);
 
 private:
     friend class MediaTranscodingServiceTest;