commit 8d7d5613ef5284ae8be6d771aea51acf1a79f77b
author Aayush Soni <aayush.soni@ittiam.com> Wed Jul 28 14:36:58 2021 +0530
committer Aayush Soni <aayush.soni@ittiam.com> Thu Aug 12 09:54:51 2021 +0530
tree 79ae700742a7fe04a57723b48fcd8f5591988653
parent 953b19dff77ccb711e5a1ac6a440e21505b88314

C2SoftMpeg4Dec: Fix memory leak in onRelease

Test: POC in bug description
      atest VtsHalMediaC2V1_0TargetVideoDecTest
      atest -c CtsMediaV2TestCases:CodecDecoderTest

Bug: 193759243

Change-Id: I1b4511e733d02a2f573bcb5475b778beccaccbae

media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp

diff --git a/media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp b/media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp
index ddd312f..60d6b44 100644
--- a/media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp
+++ b/media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp
@@ -243,11 +243,13 @@
 }
 
 c2_status_t C2SoftMpeg4Dec::onStop() {
-    if (mInitialized) {
-        if (mDecHandle) {
+    if (mDecHandle) {
+        if (mInitialized) {
             PVCleanUpVideoDecoder(mDecHandle);
+            mInitialized = false;
         }
-        mInitialized = false;
+        delete mDecHandle;
+        mDecHandle = nullptr;
     }
     for (int32_t i = 0; i < kNumOutputBuffers; ++i) {
         if (mOutputBuffer[i]) {
@@ -269,23 +271,10 @@
 }
 
 void C2SoftMpeg4Dec::onRelease() {
-    if (mInitialized) {
-        if (mDecHandle) {
-            PVCleanUpVideoDecoder(mDecHandle);
-            delete mDecHandle;
-            mDecHandle = nullptr;
-        }
-        mInitialized = false;
-    }
+    (void)onStop();
     if (mOutBlock) {
         mOutBlock.reset();
     }
-    for (int32_t i = 0; i < kNumOutputBuffers; ++i) {
-        if (mOutputBuffer[i]) {
-            free(mOutputBuffer[i]);
-            mOutputBuffer[i] = nullptr;
-        }
-    }
 }
 
 c2_status_t C2SoftMpeg4Dec::onFlush_sm() {